Message ID | 20230930223046.22896-8-michael@niedermayer.cc |
---|---|
State | Accepted |
Commit | 9b00b5734d9868971cb6e6cda0f3b8eeed93be9e |
Headers | show |
Series | [FFmpeg-devel,01/15] avformat/concatdec: Check in/outpoint for overflow | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | success | Make finished |
yinshiyou/make_fate_loongarch64 | success | Make fate finished |
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
Michael Niedermayer (12023-10-01): > Fixes: signed integer overflow: 9230955872951340 - -9223372036854775808 cannot be represented in type 'long' > Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6330481893572608 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavformat/sbgdec.c | 7 +++++++ > 1 file changed, 7 insertions(+) No objection either. Regards,
diff --git a/libavformat/sbgdec.c b/libavformat/sbgdec.c index 73b5be9007d..b2662ea4188 100644 --- a/libavformat/sbgdec.c +++ b/libavformat/sbgdec.c @@ -1447,6 +1447,13 @@ static av_cold int sbg_read_header(AVFormatContext *avf) st->duration = script.end_ts == AV_NOPTS_VALUE ? AV_NOPTS_VALUE : av_rescale(script.end_ts - script.start_ts, sbg->sample_rate, AV_TIME_BASE); + + if (st->duration != AV_NOPTS_VALUE && ( + st->duration < 0 || st->start_time > INT64_MAX - st->duration)) { + r = AVERROR_INVALIDDATA; + goto fail; + } + sti->cur_dts = st->start_time; r = encode_intervals(&script, st->codecpar, &inter); if (r < 0)
Fixes: signed integer overflow: 9230955872951340 - -9223372036854775808 cannot be represented in type 'long' Fixes: 51896/clusterfuzz-testcase-minimized-ffmpeg_dem_SBG_fuzzer-6330481893572608 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavformat/sbgdec.c | 7 +++++++ 1 file changed, 7 insertions(+)