diff mbox series

[FFmpeg-devel] avcodec/libkvazaar: Bump minimum version to 2.0.0

Message ID 20231002170328.67399-1-johnmather@sidefx.com
State Accepted
Commit 7251dfdcee2f2ec83d9de10334257531762fe42b
Headers show
Series [FFmpeg-devel] avcodec/libkvazaar: Bump minimum version to 2.0.0 | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

John Mather Oct. 2, 2023, 5:03 p.m. UTC
0cd8769207f utilized the rc_algorithm member of the kvz_config struct, which
was introduced in Kvazaar 2.0.0. This patch bumps the minimum version of
Kvazaar to 2.0.0 so that FFmpeg compiles successfully.

Signed-off-by: John Mather <johnmather@sidefx.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jan Ekström Oct. 11, 2023, 6:56 p.m. UTC | #1
On Mon, Oct 2, 2023 at 8:04 PM John Mather via ffmpeg-devel
<ffmpeg-devel@ffmpeg.org> wrote:
>
> 0cd8769207f utilized the rc_algorithm member of the kvz_config struct, which
> was introduced in Kvazaar 2.0.0. This patch bumps the minimum version of
> Kvazaar to 2.0.0 so that FFmpeg compiles successfully.
>
> Signed-off-by: John Mather <johnmather@sidefx.com>

LGTM.

Verified that the change indeed occurred between 1.3.0 and 2.0.0 and
that with this change 1.3.0 does not pass configure, and 2.0.0 both
passes configure as well as builds.

Applied as 7251dfdcee2f2ec83d9de10334257531762fe42b to master, and
then remembered that the description after prefix should have been
lowercase .-. .

Jan
diff mbox series

Patch

diff --git a/configure b/configure
index 04bb9fe9dd..3118cc0502 100755
--- a/configure
+++ b/configure
@@ -6718,7 +6718,7 @@  enabled libilbc           && require libilbc ilbc.h WebRtcIlbcfix_InitDecode -li
 enabled libjxl            && require_pkg_config libjxl "libjxl >= 0.7.0" jxl/decode.h JxlDecoderVersion &&
                              require_pkg_config libjxl_threads "libjxl_threads >= 0.7.0" jxl/thread_parallel_runner.h JxlThreadParallelRunner
 enabled libklvanc         && require libklvanc libklvanc/vanc.h klvanc_context_create -lklvanc
-enabled libkvazaar        && require_pkg_config libkvazaar "kvazaar >= 0.8.1" kvazaar.h kvz_api_get
+enabled libkvazaar        && require_pkg_config libkvazaar "kvazaar >= 2.0.0" kvazaar.h kvz_api_get
 enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_new
 
 if enabled libmfx && enabled libvpl; then