| Message ID | 20231003133720.8458-1-anton@khirnov.net |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] configure: warn when threading is disabled | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
On 10/3/2023 10:37 AM, Anton Khirnov wrote: > Explicitly state what the implications of this are. > --- > configure | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/configure b/configure > index 8a1a1b8584..5ba2698798 100755 > --- a/configure > +++ b/configure > @@ -7493,6 +7493,12 @@ check_deps $CONFIG_LIST \ > > enabled threads && ! enabled pthreads && ! enabled atomics_native && die "non pthread threading without atomics not supported, try adding --enable-pthreads or --cpu=i486 or higher if you are on x86" > > +enabled threads || warn \ > + "Threading support was disabled or is not available on this platform." \ nit: The target platform > + "This means that not only is this build not multi-threaded, but also" \ > + "that the libraries from this build MUST NOT be used in a multi-threaded"\ > + "environment." > + > case $target_os in > haiku) > disable memalign
Quoting James Almer (2023-10-03 15:40:12) > On 10/3/2023 10:37 AM, Anton Khirnov wrote: > > Explicitly state what the implications of this are. > > --- > > configure | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/configure b/configure > > index 8a1a1b8584..5ba2698798 100755 > > --- a/configure > > +++ b/configure > > @@ -7493,6 +7493,12 @@ check_deps $CONFIG_LIST \ > > > > enabled threads && ! enabled pthreads && ! enabled atomics_native && die "non pthread threading without atomics not supported, try adding --enable-pthreads or --cpu=i486 or higher if you are on x86" > > > > +enabled threads || warn \ > > + "Threading support was disabled or is not available on this platform." \ > > nit: The target platform very right, fixed locally
diff --git a/configure b/configure index 8a1a1b8584..5ba2698798 100755 --- a/configure +++ b/configure @@ -7493,6 +7493,12 @@ check_deps $CONFIG_LIST \ enabled threads && ! enabled pthreads && ! enabled atomics_native && die "non pthread threading without atomics not supported, try adding --enable-pthreads or --cpu=i486 or higher if you are on x86" +enabled threads || warn \ + "Threading support was disabled or is not available on this platform." \ + "This means that not only is this build not multi-threaded, but also" \ + "that the libraries from this build MUST NOT be used in a multi-threaded"\ + "environment." + case $target_os in haiku) disable memalign