diff mbox series

[FFmpeg-devel] configure: improve libmfx deprecation warning

Message ID 20231006125925.203760-1-leo.izen@gmail.com
State Accepted
Commit 1e888462a1ea2b3f1144b536fd2702d95759ba43
Headers show
Series [FFmpeg-devel] configure: improve libmfx deprecation warning | expand

Commit Message

Leo Izen Oct. 6, 2023, 12:59 p.m. UTC 
The libmfx deprecation warning tells you to build against libmfx 1.x,
but the actual solution is to use --enable-libvpl instead of using
--enable-libmfx. Update the warning message to reflect this.

Signed-off-by: Leo Izen <leo.izen@gmail.com>
---
 configure | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Leo Izen Oct. 11, 2023, 6:59 p.m. UTC | #1 
On 10/6/23 08:59, Leo Izen wrote:
> The libmfx deprecation warning tells you to build against libmfx 1.x,
> but the actual solution is to use --enable-libvpl instead of using
> --enable-libmfx. Update the warning message to reflect this.
> 

Will apply soon if there are no objections.

- Leo Izen
diff mbox series

Patch

diff --git a/configure b/configure
index 8a1a1b8584..97b3b29ae5 100755
--- a/configure
+++ b/configure
@@ -6730,8 +6730,7 @@  elif enabled libmfx; then
       { require libmfx "mfxvideo.h mfxdefs.h" MFXInit "-llibmfx $advapi32_extralibs" &&
         { test_cpp_condition mfxdefs.h "MFX_VERSION >= 1028 && MFX_VERSION < 2000" || die "ERROR: libmfx version must be >= 1.28 and < 2.0"; }  &&
         warn "using libmfx without pkg-config"; } } &&
-    warn "build FFmpeg against libmfx 1.x, obsolete features of libmfx such as OPAQUE memory,\n"\
-         "multi-frame encode, user plugins and LA_EXT rate control mode are enabled"
+    warn "libmfx is deprecated. Please run configure with --enable-libvpl to use libvpl instead."
 elif enabled libvpl; then
 # Consider pkg-config only. The name of libmfx is still passed to check_pkg_config function for --enable-libvpl option
 # because QSV has dependency on libmfx, we can use the same dependency if using libmfx in this check. The package name