diff mbox series

[FFmpeg-devel,1/7] avcodec/packet: add a decoded frame cropping side data type

Message ID 20231007162503.1057-2-jamrial@gmail.com
State New
Headers show
Series Container level frame cropping parameters | expand

Commit Message

James Almer Oct. 7, 2023, 4:24 p.m. UTC
Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/packet.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Andreas Rheinhardt Oct. 10, 2023, 11:30 a.m. UTC | #1
James Almer:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/packet.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/libavcodec/packet.h b/libavcodec/packet.h
> index b19409b719..6053d43c44 100644
> --- a/libavcodec/packet.h
> +++ b/libavcodec/packet.h
> @@ -299,6 +299,20 @@ enum AVPacketSideDataType {
>       */
>      AV_PKT_DATA_DYNAMIC_HDR10_PLUS,
>  
> +    /**
> +     * The number of pixels to discard from the
> +     * top/bottom/left/right border of the decoded frame to obtain the sub-rectangle
> +     * intended for presentation.
> +     *
> +     * @code
> +     * u32le crop_top
> +     * u32le crop_bottom
> +     * u32le crop_left
> +     * u32le crop_right
> +     * @endcode
> +     */
> +    AV_PKT_DATA_FRAME_CROPPING,
> +
>      /**
>       * The number of side data types.
>       * This is not part of the public API/ABI in the sense that it may

The data in ISOBMFF clap boxes is more general than that, therefore this
should be used so that this data can be preserved during remuxes.
See the earlier patchset by Neil Birkbeck for it:
https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/261465.html (there
is more of this discussion in subsequent months).

- Andreas
diff mbox series

Patch

diff --git a/libavcodec/packet.h b/libavcodec/packet.h
index b19409b719..6053d43c44 100644
--- a/libavcodec/packet.h
+++ b/libavcodec/packet.h
@@ -299,6 +299,20 @@  enum AVPacketSideDataType {
      */
     AV_PKT_DATA_DYNAMIC_HDR10_PLUS,
 
+    /**
+     * The number of pixels to discard from the
+     * top/bottom/left/right border of the decoded frame to obtain the sub-rectangle
+     * intended for presentation.
+     *
+     * @code
+     * u32le crop_top
+     * u32le crop_bottom
+     * u32le crop_left
+     * u32le crop_right
+     * @endcode
+     */
+    AV_PKT_DATA_FRAME_CROPPING,
+
     /**
      * The number of side data types.
      * This is not part of the public API/ABI in the sense that it may