diff mbox series

[FFmpeg-devel] checkasm: test with random bw value

Message ID 20231109202653.18303-1-remi@remlab.net
State Accepted
Commit 427347309b44471448668b47cccf9360f177bfe9
Headers show
Series [FFmpeg-devel] checkasm: test with random bw value | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Rémi Denis-Courmont Nov. 9, 2023, 8:26 p.m. UTC
With a value of zero, the function is a glorified memory copy.
---
 tests/checkasm/sbrdsp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Martin Storsjö Nov. 9, 2023, 9:32 p.m. UTC | #1
On Thu, 9 Nov 2023, Rémi Denis-Courmont wrote:

> With a value of zero, the function is a glorified memory copy.
> ---
> tests/checkasm/sbrdsp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/sbrdsp.c b/tests/checkasm/sbrdsp.c
> index 2fb14d5bf8..5cc3b33215 100644
> --- a/tests/checkasm/sbrdsp.c
> +++ b/tests/checkasm/sbrdsp.c
> @@ -190,8 +190,8 @@ static void test_hf_gen(void)
>     for (i = 2; i < 64; i += 2) {
>         memset(dst0, 0, 128 * 2 * sizeof(INTFLOAT));
>         memset(dst1, 0, 128 * 2 * sizeof(INTFLOAT));
> -        call_ref(dst0, low, alpha0, alpha1, 0.0, i, 128);
> -        call_new(dst1, low, alpha0, alpha1, 0.0, i, 128);
> +        call_ref(dst0, low, alpha0, alpha1, bw, i, 128);
> +        call_new(dst1, low, alpha0, alpha1, bw, i, 128);
>         if (!float_near_abs_eps_array((INTFLOAT *)dst0, (INTFLOAT *)dst1, EPS, 128 * 2))
>             fail();
>         bench_new(dst1, low, alpha0, alpha1, bw, i, 128);
> -- 
> 2.42.0

LGTM, also tested on i386, x86_64, armv7 and aarch64.

// Martin
diff mbox series

Patch

diff --git a/tests/checkasm/sbrdsp.c b/tests/checkasm/sbrdsp.c
index 2fb14d5bf8..5cc3b33215 100644
--- a/tests/checkasm/sbrdsp.c
+++ b/tests/checkasm/sbrdsp.c
@@ -190,8 +190,8 @@  static void test_hf_gen(void)
     for (i = 2; i < 64; i += 2) {
         memset(dst0, 0, 128 * 2 * sizeof(INTFLOAT));
         memset(dst1, 0, 128 * 2 * sizeof(INTFLOAT));
-        call_ref(dst0, low, alpha0, alpha1, 0.0, i, 128);
-        call_new(dst1, low, alpha0, alpha1, 0.0, i, 128);
+        call_ref(dst0, low, alpha0, alpha1, bw, i, 128);
+        call_new(dst1, low, alpha0, alpha1, bw, i, 128);
         if (!float_near_abs_eps_array((INTFLOAT *)dst0, (INTFLOAT *)dst1, EPS, 128 * 2))
             fail();
         bench_new(dst1, low, alpha0, alpha1, bw, i, 128);