diff mbox series

[FFmpeg-devel] avformat/hlsenc: remove unnessecery av_dict_free operations

Message ID 20231117133009.66968-1-lq@chinaffmpeg.org
State New
Headers show
Series [FFmpeg-devel] avformat/hlsenc: remove unnessecery av_dict_free operations | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Liu Steven Nov. 17, 2023, 1:30 p.m. UTC 
The option will be freed at the end of the hls_window function,
And will go to fail label call av_dict_free if
every open operation return failed.

Signed-off-by: Steven Liu <lq@chinaffmpeg.org>
---
 libavformat/hlsenc.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 7049956dd7..27f558abd4 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -1588,7 +1588,6 @@  static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
     set_http_options(s, &options, hls);
     snprintf(temp_filename, sizeof(temp_filename), use_temp_file ? "%s.tmp" : "%s", vs->m3u8_name);
     ret = hlsenc_io_open(s, byterange_mode ? &hls->m3u8_out : &vs->out, temp_filename, &options);
-    av_dict_free(&options);
     if (ret < 0) {
         if (hls->ignore_io_errors)
             ret = 0;
@@ -1647,7 +1646,6 @@  static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
         set_http_options(vs->vtt_avf, &options, hls);
         snprintf(temp_vtt_filename, sizeof(temp_vtt_filename), use_temp_file ? "%s.tmp" : "%s", vs->vtt_m3u8_name);
         ret = hlsenc_io_open(s, &hls->sub_m3u8_out, temp_vtt_filename, &options);
-        av_dict_free(&options);
         if (ret < 0) {
             if (hls->ignore_io_errors)
                 ret = 0;