diff mbox series

[FFmpeg-devel] avcodec/av1dec: Fix resolving zero divisor

Message ID 20231130122853.26758-1-michael@niedermayer.cc
State Accepted
Commit 22daf2148fc072f8f347af939f88b3af7896ab60
Headers show
Series [FFmpeg-devel] avcodec/av1dec: Fix resolving zero divisor | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Michael Niedermayer Nov. 30, 2023, 12:28 p.m. UTC 
Fixes: Out of array read
Fixes: global-buffer-overflow-AV1

Found-by: "Leonelli, Matteo" <matteo.leonelli@cispa.de>
Tested-by: "Wang, Fei W" <fei.w.wang@intel.com>
Reviewed-by: "Wang, Fei W" <fei.w.wang@intel.com>
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/av1dec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index 6114cb78e65..4dcde234c6c 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1dec.c
@@ -177,7 +177,7 @@  static uint8_t get_shear_params_valid(AV1DecContext *s, int idx)
     int16_t alpha, beta, gamma, delta, divf, divs;
     int64_t v, w;
     int32_t *param = &s->cur_frame.gm_params[idx][0];
-    if (param[2] < 0)
+    if (param[2] <= 0)
         return 0;
 
     alpha = av_clip_int16(param[2] - (1 << AV1_WARPEDMODEL_PREC_BITS));