diff mbox series

[FFmpeg-devel] tools/general_assembly: avoid using DateTime->is_between()

Message ID 20231207164912.1428-1-anton@khirnov.net
State Accepted
Commit 5fdbc2a1f96b477c420a858d835b4158b9eaffcf
Headers show
Series [FFmpeg-devel] tools/general_assembly: avoid using DateTime->is_between() | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Anton Khirnov Dec. 7, 2023, 4:49 p.m. UTC 
It was added relatively recently and is not available everywhere.
---
 tools/general_assembly.pl | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Niedermayer Dec. 7, 2023, 7:19 p.m. UTC | #1 
On Thu, Dec 07, 2023 at 05:49:12PM +0100, Anton Khirnov wrote:
> It was added relatively recently and is not available everywhere.
> ---
>  tools/general_assembly.pl | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

works fine, even on my oldest box

thx

[...]
diff mbox series

Patch

diff --git a/tools/general_assembly.pl b/tools/general_assembly.pl
index aa10384aef..0dafa82e27 100755
--- a/tools/general_assembly.pl
+++ b/tools/general_assembly.pl
@@ -72,7 +72,7 @@  sub get_date_range {
     # date when the regular update rule is first applied
     my $date_first_regular = DateTime->new(year => 2024);
 
-    if ($now->is_between($date_ga_rule, $date_first_regular)) {
+    if ($now > $date_ga_rule && $now < $date_first_regular) {
         return ($date_ga_rule->clone()->set_year($date_ga_rule->year - 3), $date_ga_rule);
     }
 
@@ -123,7 +123,7 @@  foreach my $line (@shortlog) {
 
 foreach my $entry (@extra_members) {
     my $elected = $entry->[2];
-    if ($date->is_between($elected, $elected->clone()->set_year($elected->year + 2))) {
+    if ($date > $elected && $date < $elected->clone()->set_year($elected->year + 2)) {
         $assembly{$entry->[0]} = $entry->[1];
     }
 }