diff mbox series

[FFmpeg-devel] doc/bitstream_filters: add filter_units practical examples for removing closed captions

Message ID 20231210013550.786075-1-marth64@proxyid.net
State New
Headers show
Series [FFmpeg-devel] doc/bitstream_filters: add filter_units practical examples for removing closed captions | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Marth64 Dec. 10, 2023, 1:35 a.m. UTC
---
 doc/bitstream_filters.texi | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Leo Izen Dec. 10, 2023, 3:06 a.m. UTC | #1
On 12/9/23 20:35, Marth64 wrote:
> ---
>   doc/bitstream_filters.texi | 18 ++++++++++++++++++
>   1 file changed, 18 insertions(+)
> 

Make sure when you generate the second version of a patch with git 
format-patch you pass the -v2 argument, e.g.

git format-patch -v2 -o outgoing/ master

Otherwise it can get a little bit difficult for reviewers to track the 
versions. I have no comments on the patch itself, in either direction.

- Leo Izen (Traneptora)
Marth64 Dec. 10, 2023, 3:17 a.m. UTC | #2
Thank you!

On Sat, Dec 9, 2023 at 9:06 PM Leo Izen <leo.izen@gmail.com> wrote:

> On 12/9/23 20:35, Marth64 wrote:
> > ---
> >   doc/bitstream_filters.texi | 18 ++++++++++++++++++
> >   1 file changed, 18 insertions(+)
> >
>
> Make sure when you generate the second version of a patch with git
> format-patch you pass the -v2 argument, e.g.
>
> git format-patch -v2 -o outgoing/ master
>
> Otherwise it can get a little bit difficult for reviewers to track the
> versions. I have no comments on the patch itself, in either direction.
>
> - Leo Izen (Traneptora)
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Stefano Sabatini Dec. 11, 2023, 11:29 p.m. UTC | #3
On date Saturday 2023-12-09 19:35:50 -0600, Marth64 wrote:
> ---
>  doc/bitstream_filters.texi | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
> index c63c20370f..d2ad6e78ff 100644
> --- a/doc/bitstream_filters.texi
> +++ b/doc/bitstream_filters.texi
> @@ -213,6 +213,24 @@ To remove all AUDs, SEI and filler from an H.265 stream:
>  ffmpeg -i INPUT -c:v copy -bsf:v 'filter_units=remove_types=35|38-40' OUTPUT
>  @end example
>  
> +SEI messages are commonly used to contain Closed Captions as well as other metadata such as dynamic HDR.
> +This filter can be used to remove the SEI messages if desired.
> +
> +To remove SEI messages (including CC) from a MPEG-2 stream:
> +@example
> +ffmpeg -i INPUT -c:v copy -bsf:v 'filter_units=remove_types=178' OUTPUT
> +@end example
> +
> +To remove SEI messages (including CC) from a H264 stream:
> +@example
> +ffmpeg -i INPUT -c:v copy -bsf:v 'filter_units=remove_types=6' OUTPUT
> +@end example
> +
> +To remove SEI messages (including CC and dynamic HDR) from a HEVC stream:
> +@example
> +ffmpeg -i INPUT -c:v copy -bsf:v 'filter_units=remove_types=39' OUTPUT
> +@end example

Shall be good, but probably we can still do a bit better, by making
explicit the common pattern.

Something as:
...

SEI messages are commonly used to contain Closed Captions as well as
other metadata such as dynamic HDR.

This filter can be used to remove the SEI messages, including CC,
given the bitstream SEI unit type (which changes depending on the
video stream).

To remove SEI messages (including CC) from a MPEG-2 stream:
...
diff mbox series

Patch

diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi
index c63c20370f..d2ad6e78ff 100644
--- a/doc/bitstream_filters.texi
+++ b/doc/bitstream_filters.texi
@@ -213,6 +213,24 @@  To remove all AUDs, SEI and filler from an H.265 stream:
 ffmpeg -i INPUT -c:v copy -bsf:v 'filter_units=remove_types=35|38-40' OUTPUT
 @end example
 
+SEI messages are commonly used to contain Closed Captions as well as other metadata such as dynamic HDR.
+This filter can be used to remove the SEI messages if desired.
+
+To remove SEI messages (including CC) from a MPEG-2 stream:
+@example
+ffmpeg -i INPUT -c:v copy -bsf:v 'filter_units=remove_types=178' OUTPUT
+@end example
+
+To remove SEI messages (including CC) from a H264 stream:
+@example
+ffmpeg -i INPUT -c:v copy -bsf:v 'filter_units=remove_types=6' OUTPUT
+@end example
+
+To remove SEI messages (including CC and dynamic HDR) from a HEVC stream:
+@example
+ffmpeg -i INPUT -c:v copy -bsf:v 'filter_units=remove_types=39' OUTPUT
+@end example
+
 @section hapqa_extract
 
 Extract Rgb or Alpha part of an HAPQA file, without recompression, in order to create an HAPQ or an HAPAlphaOnly file.