diff mbox series

[FFmpeg-devel] lavc/aacpsdsp: fix R-V V stereo interpolate

Message ID 20231217151915.42895-1-remi@remlab.net
State Accepted
Commit cdd38a2ffe9a6a092b5aee34cc5fe7fe20b72148
Headers show
Series [FFmpeg-devel] lavc/aacpsdsp: fix R-V V stereo interpolate | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Rémi Denis-Courmont Dec. 17, 2023, 3:19 p.m. UTC 
The penultimate loop iteration could pick any vl such that:
 vlenb/4 < vl <= vlenb/2
Thus if the total length is not a multiple of vlenb/2, the vfadd.vf
on the penultimate iteration would yield corrupt values for the last
iteration.

To avoid this, force vl = vlen/2 until the last iteration. Unfortunately
this latent bug is not reproducible with either hardware or QEMU as of now.
---
 libavcodec/riscv/aacpsdsp_rvv.S | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/libavcodec/riscv/aacpsdsp_rvv.S b/libavcodec/riscv/aacpsdsp_rvv.S
index f46b35fe91..a79d7d7818 100644
--- a/libavcodec/riscv/aacpsdsp_rvv.S
+++ b/libavcodec/riscv/aacpsdsp_rvv.S
@@ -234,7 +234,8 @@  func ff_ps_stereo_interpolate_rvv, zve32f
         vfmacc.vf    v22, ft3, v24
         fmul.s       ft3, ft3, ft4
 1:
-        vsetvli   t0, a4, e32, m2, ta, ma
+        min       t0, t0, a4
+        vsetvli   zero, t0, e32, m2, ta, ma
         vlseg2e32.v v0, (a0)     // v0:l_re, v2:l_im
         sub       a4, a4, t0
         vlseg2e32.v v4, (a1)    // v4:r_re, v6:r_im