| Message ID | 20231221112310.1214-1-tong1.wu@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] avutil/hwcontext_d3d12va: remove an unused function | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Thu, 21 Dec 2023, Tong Wu wrote: > Signed-off-by: Tong Wu <tong1.wu@intel.com> > --- > libavutil/hwcontext_d3d12va.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c > index 1600d94cb0..4995518dbd 100644 > --- a/libavutil/hwcontext_d3d12va.c > +++ b/libavutil/hwcontext_d3d12va.c > @@ -71,15 +71,6 @@ static void d3d12va_default_unlock(void *ctx) > ReleaseMutex(ctx); > } > > -DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum AVPixelFormat pix_fmt) > -{ > - switch (pix_fmt) { > - case AV_PIX_FMT_NV12:return DXGI_FORMAT_NV12; > - case AV_PIX_FMT_P010:return DXGI_FORMAT_P010; > - default: return DXGI_FORMAT_UNKNOWN; > - } > -} > - > static int d3d12va_fence_completion(AVD3D12VASyncContext *psync_ctx) > { > uint64_t completion = ID3D12Fence_GetCompletedValue(psync_ctx->fence); > -- > 2.41.0.windows.1 LGTM, thanks. It might be good to mention that it was lacking a public declaration, which caused builds with -Werror=missing-prototypes to fail, and the reason why it was left behind and not needed. // Martin
> >On Thu, 21 Dec 2023, Tong Wu wrote: > >> Signed-off-by: Tong Wu <tong1.wu@intel.com> >> --- >> libavutil/hwcontext_d3d12va.c | 9 --------- >> 1 file changed, 9 deletions(-) >> >> diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c >> index 1600d94cb0..4995518dbd 100644 >> --- a/libavutil/hwcontext_d3d12va.c >> +++ b/libavutil/hwcontext_d3d12va.c >> @@ -71,15 +71,6 @@ static void d3d12va_default_unlock(void *ctx) >> ReleaseMutex(ctx); >> } >> >> -DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum AVPixelFormat >pix_fmt) >> -{ >> - switch (pix_fmt) { >> - case AV_PIX_FMT_NV12:return DXGI_FORMAT_NV12; >> - case AV_PIX_FMT_P010:return DXGI_FORMAT_P010; >> - default: return DXGI_FORMAT_UNKNOWN; >> - } >> -} >> - >> static int d3d12va_fence_completion(AVD3D12VASyncContext *psync_ctx) >> { >> uint64_t completion = ID3D12Fence_GetCompletedValue(psync_ctx- >>fence); >> -- >> 2.41.0.windows.1 > >LGTM, thanks. > >It might be good to mention that it was lacking a public declaration, >which caused builds with -Werror=missing-prototypes to fail, and the >reason why it was left behind and not needed. > >// Martin Thanks, updated it.
diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c index 1600d94cb0..4995518dbd 100644 --- a/libavutil/hwcontext_d3d12va.c +++ b/libavutil/hwcontext_d3d12va.c @@ -71,15 +71,6 @@ static void d3d12va_default_unlock(void *ctx) ReleaseMutex(ctx); } -DXGI_FORMAT av_d3d12va_map_sw_to_hw_format(enum AVPixelFormat pix_fmt) -{ - switch (pix_fmt) { - case AV_PIX_FMT_NV12:return DXGI_FORMAT_NV12; - case AV_PIX_FMT_P010:return DXGI_FORMAT_P010; - default: return DXGI_FORMAT_UNKNOWN; - } -} - static int d3d12va_fence_completion(AVD3D12VASyncContext *psync_ctx) { uint64_t completion = ID3D12Fence_GetCompletedValue(psync_ctx->fence);
Signed-off-by: Tong Wu <tong1.wu@intel.com> --- libavutil/hwcontext_d3d12va.c | 9 --------- 1 file changed, 9 deletions(-)