| Message ID | 20231221123453.8125-3-jamrial@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/3] avutil/hwcontext_d3d12va: cast the input pointer array argument on av_image_copy calls | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Thu, 21 Dec 2023, James Almer wrote: > Removes -Wunused-variable warnings. > > Signed-off-by: James Almer <jamrial@gmail.com> > --- > Were this meant to be used? Or are just a remnant of a previous interation of > the set? > > libavutil/hwcontext_d3d12va.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c > index 4ce29f250c..46832fd19b 100644 > --- a/libavutil/hwcontext_d3d12va.c > +++ b/libavutil/hwcontext_d3d12va.c > @@ -173,7 +173,6 @@ fail: > > static void d3d12va_frames_uninit(AVHWFramesContext *ctx) > { > - AVD3D12VAFramesContext *frames_hwctx = ctx->hwctx; > D3D12VAFramesContext *s = ctx->internal->priv; Here, I'd prefer to get rid of the extra spaces once the other line, which it was aligned to, is gone. > static int d3d12va_frames_init(AVHWFramesContext *ctx) > { > AVD3D12VAFramesContext *hwctx = ctx->hwctx; > - AVD3D12VADeviceContext *device_hwctx = ctx->device_ctx->hwctx; > - D3D12VAFramesContext *s = ctx->internal->priv; Ditto // Martin
On 12/21/2023 9:42 AM, Martin Storsjö wrote: > On Thu, 21 Dec 2023, James Almer wrote: > >> Removes -Wunused-variable warnings. >> >> Signed-off-by: James Almer <jamrial@gmail.com> >> --- >> Were this meant to be used? Or are just a remnant of a previous >> interation of >> the set? >> >> libavutil/hwcontext_d3d12va.c | 4 ---- >> 1 file changed, 4 deletions(-) >> >> diff --git a/libavutil/hwcontext_d3d12va.c >> b/libavutil/hwcontext_d3d12va.c >> index 4ce29f250c..46832fd19b 100644 >> --- a/libavutil/hwcontext_d3d12va.c >> +++ b/libavutil/hwcontext_d3d12va.c >> @@ -173,7 +173,6 @@ fail: >> >> static void d3d12va_frames_uninit(AVHWFramesContext *ctx) >> { >> - AVD3D12VAFramesContext *frames_hwctx = ctx->hwctx; >> D3D12VAFramesContext *s = ctx->internal->priv; > > Here, I'd prefer to get rid of the extra spaces once the other line, > which it was aligned to, is gone. > >> static int d3d12va_frames_init(AVHWFramesContext *ctx) >> { >> AVD3D12VAFramesContext *hwctx = ctx->hwctx; >> - AVD3D12VADeviceContext *device_hwctx = ctx->device_ctx->hwctx; >> - D3D12VAFramesContext *s = ctx->internal->priv; > > Ditto Amended locally. Thanks.
>-----Original Message----- >From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of James >Almer >Sent: Thursday, December 21, 2023 8:47 PM >To: ffmpeg-devel@ffmpeg.org >Subject: Re: [FFmpeg-devel] [PATCH 3/3] avutil/hwcontext_d3d12va: remove >unused variables > >On 12/21/2023 9:42 AM, Martin Storsjö wrote: >> On Thu, 21 Dec 2023, James Almer wrote: >> >>> Removes -Wunused-variable warnings. >>> >>> Signed-off-by: James Almer <jamrial@gmail.com> >>> --- >>> Were this meant to be used? Or are just a remnant of a previous >>> interation of >>> the set? They are just leftovers of the previous version. Patch set LGTM, thanks. >>> >>> libavutil/hwcontext_d3d12va.c | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/libavutil/hwcontext_d3d12va.c >>> b/libavutil/hwcontext_d3d12va.c >>> index 4ce29f250c..46832fd19b 100644 >>> --- a/libavutil/hwcontext_d3d12va.c >>> +++ b/libavutil/hwcontext_d3d12va.c >>> @@ -173,7 +173,6 @@ fail: >>> >>> static void d3d12va_frames_uninit(AVHWFramesContext *ctx) >>> { >>> - AVD3D12VAFramesContext *frames_hwctx = ctx->hwctx; >>> D3D12VAFramesContext *s = ctx->internal->priv; >> >> Here, I'd prefer to get rid of the extra spaces once the other line, >> which it was aligned to, is gone. >> >>> static int d3d12va_frames_init(AVHWFramesContext *ctx) >>> { >>> AVD3D12VAFramesContext *hwctx = ctx->hwctx; >>> - AVD3D12VADeviceContext *device_hwctx = ctx->device_ctx->hwctx; >>> - D3D12VAFramesContext *s = ctx->internal->priv; >> >> Ditto > >Amended locally. Thanks. >_______________________________________________ >ffmpeg-devel mailing list >ffmpeg-devel@ffmpeg.org >https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > >To unsubscribe, visit link above, or email >ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c index 4ce29f250c..46832fd19b 100644 --- a/libavutil/hwcontext_d3d12va.c +++ b/libavutil/hwcontext_d3d12va.c @@ -173,7 +173,6 @@ fail: static void d3d12va_frames_uninit(AVHWFramesContext *ctx) { - AVD3D12VAFramesContext *frames_hwctx = ctx->hwctx; D3D12VAFramesContext *s = ctx->internal->priv; D3D12_OBJECT_RELEASE(s->sync_ctx.fence); @@ -281,8 +280,6 @@ fail: static int d3d12va_frames_init(AVHWFramesContext *ctx) { AVD3D12VAFramesContext *hwctx = ctx->hwctx; - AVD3D12VADeviceContext *device_hwctx = ctx->device_ctx->hwctx; - D3D12VAFramesContext *s = ctx->internal->priv; int i; for (i = 0; i < FF_ARRAY_ELEMS(supported_formats); i++) { @@ -335,7 +332,6 @@ static int d3d12va_transfer_get_formats(AVHWFramesContext *ctx, enum AVHWFrameTransferDirection dir, enum AVPixelFormat **formats) { - D3D12VAFramesContext *s = ctx->internal->priv; enum AVPixelFormat *fmts; fmts = av_malloc_array(2, sizeof(*fmts));
Removes -Wunused-variable warnings. Signed-off-by: James Almer <jamrial@gmail.com> --- Were this meant to be used? Or are just a remnant of a previous interation of the set? libavutil/hwcontext_d3d12va.c | 4 ---- 1 file changed, 4 deletions(-)