diff mbox series

[FFmpeg-devel,1/2] checkasm/takdsp: add decorrelate_sf test

Message ID 20231222011549.16057-1-jamrial@gmail.com
State New
Headers show
Series [FFmpeg-devel,1/2] checkasm/takdsp: add decorrelate_sf test | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

James Almer Dec. 22, 2023, 1:15 a.m. UTC 
Signed-off-by: James Almer <jamrial@gmail.com>
---
 tests/checkasm/takdsp.c | 36 +++++++++++++++++++++++++++++++++---
 1 file changed, 33 insertions(+), 3 deletions(-)

Comments

Martin Storsjö Dec. 22, 2023, 9:52 a.m. UTC | #1 
On Thu, 21 Dec 2023, James Almer wrote:

> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
> tests/checkasm/takdsp.c | 36 +++++++++++++++++++++++++++++++++---
> 1 file changed, 33 insertions(+), 3 deletions(-)

> @@ -113,6 +113,35 @@ static void test_decorrelate_sm(TAKDSPContext *s) {
>     report("decorrelate_sm");
> }
>
> +static void test_decorrelate_sf(TAKDSPContext *s) {
> +    declare_func(void, int32_t *, int32_t *, int, int, int);
> +
> +    if (check_func(s->decorrelate_sf, "decorrelate_sf")) {
> +        LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
> +        LOCAL_ALIGNED_32(int32_t, p1_2, [BUF_SIZE]);
> +        LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]);
> +        LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]);
> +        int dshift, dfactor;
> +
> +        randomize(p1, BUF_SIZE);
> +        memcpy(p1, p1_2, BUF_SIZE);

The source/destination of the memcpy is flipped here. And it needs a 
*sizeof(*p1).

> +        randomize(p2, BUF_SIZE);
> +        memcpy(p2_2, p2, BUF_SIZE);
> +        dshift = (rnd() & 0xF) + 1;
> +        dfactor = sign_extend(rnd(), 10);
> +        call_ref(p1, p2, BUF_SIZE, dshift, dfactor);
> +        call_new(p1_2, p2_2, BUF_SIZE, dshift, dfactor);

This function only mutates p1, not p2, so the copy of p2_2 is not entirely 
necessary.

> +
> +        if (memcmp(p2, p2_2, BUF_SIZE) != 0){

As we're mutating p1, that one is the one that should be checked. Also 
*sizeof(*p1) in the memcmp. And space between ) and {.

// Martin
diff mbox series

Patch

diff --git a/tests/checkasm/takdsp.c b/tests/checkasm/takdsp.c
index 495b7242c5..8df93cfd52 100644
--- a/tests/checkasm/takdsp.c
+++ b/tests/checkasm/takdsp.c
@@ -24,6 +24,7 @@ 
 #include "libavutil/mem_internal.h"
 
 #include "libavcodec/takdsp.h"
+#include "libavcodec/mathops.h"
 
 #include "checkasm.h"
 
@@ -33,8 +34,9 @@ 
             buf[i] = rnd(); \
     } while (0)
 
-static void test_decorrelate_ls(TAKDSPContext *s) {
 #define BUF_SIZE 1024
+
+static void test_decorrelate_ls(TAKDSPContext *s) {
     declare_func(void, int32_t *, int32_t *, int);
 
     if (check_func(s->decorrelate_ls, "decorrelate_ls")) {
@@ -60,7 +62,6 @@  static void test_decorrelate_ls(TAKDSPContext *s) {
 }
 
 static void test_decorrelate_sr(TAKDSPContext *s) {
-#define BUF_SIZE 1024
     declare_func(void, int32_t *, int32_t *, int);
 
     if (check_func(s->decorrelate_sr, "decorrelate_sr")) {
@@ -86,7 +87,6 @@  static void test_decorrelate_sr(TAKDSPContext *s) {
 }
 
 static void test_decorrelate_sm(TAKDSPContext *s) {
-#define BUF_SIZE 1024
     declare_func(void, int32_t *, int32_t *, int);
 
     if (check_func(s->decorrelate_sm, "decorrelate_sm")) {
@@ -113,6 +113,35 @@  static void test_decorrelate_sm(TAKDSPContext *s) {
     report("decorrelate_sm");
 }
 
+static void test_decorrelate_sf(TAKDSPContext *s) {
+    declare_func(void, int32_t *, int32_t *, int, int, int);
+
+    if (check_func(s->decorrelate_sf, "decorrelate_sf")) {
+        LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
+        LOCAL_ALIGNED_32(int32_t, p1_2, [BUF_SIZE]);
+        LOCAL_ALIGNED_32(int32_t, p2, [BUF_SIZE]);
+        LOCAL_ALIGNED_32(int32_t, p2_2, [BUF_SIZE]);
+        int dshift, dfactor;
+
+        randomize(p1, BUF_SIZE);
+        memcpy(p1, p1_2, BUF_SIZE);
+        randomize(p2, BUF_SIZE);
+        memcpy(p2_2, p2, BUF_SIZE);
+        dshift = (rnd() & 0xF) + 1;
+        dfactor = sign_extend(rnd(), 10);
+        call_ref(p1, p2, BUF_SIZE, dshift, dfactor);
+        call_new(p1_2, p2_2, BUF_SIZE, dshift, dfactor);
+
+        if (memcmp(p2, p2_2, BUF_SIZE) != 0){
+            fail();
+        }
+
+        bench_new(p1, p2, BUF_SIZE, dshift, dfactor);
+    }
+
+    report("decorrelate_sf");
+}
+
 void checkasm_check_takdsp(void)
 {
     TAKDSPContext s = { 0 };
@@ -121,4 +150,5 @@  void checkasm_check_takdsp(void)
     test_decorrelate_ls(&s);
     test_decorrelate_sr(&s);
     test_decorrelate_sm(&s);
+    test_decorrelate_sf(&s);
 }