Message ID | 20231226033143.1175171-1-fei.w.wang@intel.com |
---|---|
State | New |
Headers | show |
Series | [FFmpeg-devel,v1,1/2] avcodec/av1dec: Move message of OBU info back to the beginning | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | success | Make finished |
yinshiyou/make_fate_loongarch64 | success | Make fate finished |
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
On Di, 2023-12-26 at 11:31 +0800, fei.w.wang-at-intel.com@ffmpeg.org wrote: > From: Fei Wang <fei.w.wang@intel.com> > > So that can show OBU info even it doesn't have decomposed content. > > Signed-off-by: Fei Wang <fei.w.wang@intel.com> > --- > libavcodec/av1dec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index da05a0f039..e8041c1f58 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c > @@ -1200,11 +1200,12 @@ static int av1_receive_frame_internal(AVCodecContext > *avctx, AVFrame *frame) > AV1RawOBU *obu = unit->content; > const AV1RawOBUHeader *header; > > + av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", i, unit- > >type); Could you add message to indicate the content of this unit is available or not ? Thanks Haihao > + > if (!obu) > continue; > > header = &obu->header; > - av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", i, unit- > >type); > > switch (unit->type) { > case AV1_OBU_SEQUENCE_HEADER:
On Wed, 2023-12-27 at 05:35 +0000, Xiang, Haihao wrote: > On Di, 2023-12-26 at 11:31 +0800, fei.w.wang-at-intel.com@ffmpeg.org > wrote: > > From: Fei Wang <fei.w.wang@intel.com> > > > > So that can show OBU info even it doesn't have decomposed content. > > > > Signed-off-by: Fei Wang <fei.w.wang@intel.com> > > --- > > libavcodec/av1dec.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > > index da05a0f039..e8041c1f58 100644 > > --- a/libavcodec/av1dec.c > > +++ b/libavcodec/av1dec.c > > @@ -1200,11 +1200,12 @@ static int > > av1_receive_frame_internal(AVCodecContext > > *avctx, AVFrame *frame) > > AV1RawOBU *obu = unit->content; > > const AV1RawOBUHeader *header; > > > > + av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", > > i, unit- > > > type); > > Could you add message to indicate the content of this unit is > available or not ? Added in V2. Thanks Fei > > Thanks > Haihao > > > + > > if (!obu) > > continue; > > > > header = &obu->header; > > - av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", > > i, unit- > > > type); > > > > switch (unit->type) { > > case AV1_OBU_SEQUENCE_HEADER:
diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c index da05a0f039..e8041c1f58 100644 --- a/libavcodec/av1dec.c +++ b/libavcodec/av1dec.c @@ -1200,11 +1200,12 @@ static int av1_receive_frame_internal(AVCodecContext *avctx, AVFrame *frame) AV1RawOBU *obu = unit->content; const AV1RawOBUHeader *header; + av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", i, unit->type); + if (!obu) continue; header = &obu->header; - av_log(avctx, AV_LOG_DEBUG, "Obu idx:%d, obu type:%d.\n", i, unit->type); switch (unit->type) { case AV1_OBU_SEQUENCE_HEADER: