diff mbox series

[FFmpeg-devel,v3,1/7] avcodec/hevc: Add init for sao_edge_filter

Message ID 20231228082105.31311-1-jinbo@loongson.cn
State New
Headers show
Series [FFmpeg-devel,v3,1/7] avcodec/hevc: Add init for sao_edge_filter | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

金波 Dec. 28, 2023, 8:20 a.m. UTC
Forgot to init c->sao_edge_filter[idx] when idx=0/1/2/3.
After this patch, the speedup of decoding H265 4K 30FPS
30Mbps on 3A6000 is about 7% (42fps==>45fps).

Change-Id: I521999b397fa72b931a23c165cf45f276440cdfb
---
 libavcodec/loongarch/hevcdsp_init_loongarch.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Shiyou Yin Dec. 28, 2023, 8:52 a.m. UTC | #1
> -----原始邮件-----
> 发件人: jinbo <jinbo@loongson.cn>
> 发送时间:2023-12-28 16:20:59 (星期四)
> 收件人: ffmpeg-devel@ffmpeg.org
> 抄送: jinbo <jinbo@loongson.cn>
> 主题: [FFmpeg-devel] [PATCH v3 1/7] avcodec/hevc: Add init for sao_edge_filter
> 
> Forgot to init c->sao_edge_filter[idx] when idx=0/1/2/3.
> After this patch, the speedup of decoding H265 4K 30FPS
> 30Mbps on 3A6000 is about 7% (42fps==>45fps).
> 
> Change-Id: I521999b397fa72b931a23c165cf45f276440cdfb
> ---
>  libavcodec/loongarch/hevcdsp_init_loongarch.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/libavcodec/loongarch/hevcdsp_init_loongarch.c b/libavcodec/loongarch/hevcdsp_init_loongarch.c
> index 22739c6f5b..5a96f3a4c9 100644
> --- a/libavcodec/loongarch/hevcdsp_init_loongarch.c
> +++ b/libavcodec/loongarch/hevcdsp_init_loongarch.c
> @@ -167,6 +167,10 @@ void ff_hevc_dsp_init_loongarch(HEVCDSPContext *c, const int bit_depth)
>              c->put_hevc_qpel_uni_w[8][1][1] = ff_hevc_put_hevc_uni_w_qpel_hv48_8_lsx;
>              c->put_hevc_qpel_uni_w[9][1][1] = ff_hevc_put_hevc_uni_w_qpel_hv64_8_lsx;
>  
> +            c->sao_edge_filter[0] = ff_hevc_sao_edge_filter_8_lsx;
> +            c->sao_edge_filter[1] = ff_hevc_sao_edge_filter_8_lsx;
> +            c->sao_edge_filter[2] = ff_hevc_sao_edge_filter_8_lsx;
> +            c->sao_edge_filter[3] = ff_hevc_sao_edge_filter_8_lsx;
>              c->sao_edge_filter[4] = ff_hevc_sao_edge_filter_8_lsx;
>  
>              c->hevc_h_loop_filter_luma = ff_hevc_loop_filter_luma_h_8_lsx;
> -- 
> 2.20.1
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

LGTM

本邮件及其附件含有龙芯中科的商业秘密信息,仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用(包括但不限于全部或部分地泄露、复制或散发)本邮件及其附件中的信息。如果您错收本邮件,请您立即电话或邮件通知发件人并删除本邮件。 
This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.
Michael Niedermayer Dec. 28, 2023, 11:25 p.m. UTC | #2
On Thu, Dec 28, 2023 at 04:52:46PM +0800, yinshiyou-hf@loongson.cn wrote:
> > -----原始邮件-----
> > 发件人: jinbo <jinbo@loongson.cn>
> > 发送时间:2023-12-28 16:20:59 (星期四)
> > 收件人: ffmpeg-devel@ffmpeg.org
> > 抄送: jinbo <jinbo@loongson.cn>
> > 主题: [FFmpeg-devel] [PATCH v3 1/7] avcodec/hevc: Add init for sao_edge_filter
> > 
> > Forgot to init c->sao_edge_filter[idx] when idx=0/1/2/3.
> > After this patch, the speedup of decoding H265 4K 30FPS
> > 30Mbps on 3A6000 is about 7% (42fps==>45fps).
> > 
> > Change-Id: I521999b397fa72b931a23c165cf45f276440cdfb
> > ---
> >  libavcodec/loongarch/hevcdsp_init_loongarch.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/libavcodec/loongarch/hevcdsp_init_loongarch.c b/libavcodec/loongarch/hevcdsp_init_loongarch.c
> > index 22739c6f5b..5a96f3a4c9 100644
> > --- a/libavcodec/loongarch/hevcdsp_init_loongarch.c
> > +++ b/libavcodec/loongarch/hevcdsp_init_loongarch.c
> > @@ -167,6 +167,10 @@ void ff_hevc_dsp_init_loongarch(HEVCDSPContext *c, const int bit_depth)
> >              c->put_hevc_qpel_uni_w[8][1][1] = ff_hevc_put_hevc_uni_w_qpel_hv48_8_lsx;
> >              c->put_hevc_qpel_uni_w[9][1][1] = ff_hevc_put_hevc_uni_w_qpel_hv64_8_lsx;
> >  
> > +            c->sao_edge_filter[0] = ff_hevc_sao_edge_filter_8_lsx;
> > +            c->sao_edge_filter[1] = ff_hevc_sao_edge_filter_8_lsx;
> > +            c->sao_edge_filter[2] = ff_hevc_sao_edge_filter_8_lsx;
> > +            c->sao_edge_filter[3] = ff_hevc_sao_edge_filter_8_lsx;
> >              c->sao_edge_filter[4] = ff_hevc_sao_edge_filter_8_lsx;
> >  
> >              c->hevc_h_loop_filter_luma = ff_hevc_loop_filter_luma_h_8_lsx;
> > -- 
> > 2.20.1
> > 
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> > 
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
> 
> LGTM

will apply

thx

[...]
diff mbox series

Patch

diff --git a/libavcodec/loongarch/hevcdsp_init_loongarch.c b/libavcodec/loongarch/hevcdsp_init_loongarch.c
index 22739c6f5b..5a96f3a4c9 100644
--- a/libavcodec/loongarch/hevcdsp_init_loongarch.c
+++ b/libavcodec/loongarch/hevcdsp_init_loongarch.c
@@ -167,6 +167,10 @@  void ff_hevc_dsp_init_loongarch(HEVCDSPContext *c, const int bit_depth)
             c->put_hevc_qpel_uni_w[8][1][1] = ff_hevc_put_hevc_uni_w_qpel_hv48_8_lsx;
             c->put_hevc_qpel_uni_w[9][1][1] = ff_hevc_put_hevc_uni_w_qpel_hv64_8_lsx;
 
+            c->sao_edge_filter[0] = ff_hevc_sao_edge_filter_8_lsx;
+            c->sao_edge_filter[1] = ff_hevc_sao_edge_filter_8_lsx;
+            c->sao_edge_filter[2] = ff_hevc_sao_edge_filter_8_lsx;
+            c->sao_edge_filter[3] = ff_hevc_sao_edge_filter_8_lsx;
             c->sao_edge_filter[4] = ff_hevc_sao_edge_filter_8_lsx;
 
             c->hevc_h_loop_filter_luma = ff_hevc_loop_filter_luma_h_8_lsx;