diff mbox series

[FFmpeg-devel] configure: correct lensfun header function check

Message ID 20231231073308.191-1-ffmpeg@gyani.pro
State Accepted
Commit e1c1dc8347f13104bc21e4100fcf4d4dddf5e5d8
Headers show
Series [FFmpeg-devel] configure: correct lensfun header function check | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Gyan Doshi Dec. 31, 2023, 7:33 a.m. UTC
The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017
in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d
but the configure check wasn't changed.

lensfun removed lf_db_new declaration in lf 35c0017593 so configure
fails to find lensfun.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Gyan Doshi Jan. 1, 2024, 4:03 a.m. UTC | #1
On 2023-12-31 01:03 pm, Gyan Doshi wrote:
> The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017
> in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d
> but the configure check wasn't changed.
>
> lensfun removed lf_db_new declaration in lf 35c0017593 so configure
> fails to find lensfun.
> ---
This unbreaks use of the lib so plan to push in a few hours.

Regards,
Gyan


>   configure | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index cd66e42850..9262c1b650 100755
> --- a/configure
> +++ b/configure
> @@ -6776,7 +6776,7 @@ enabled libjxl            && require_pkg_config libjxl "libjxl >= 0.7.0" jxl/dec
>                                require_pkg_config libjxl_threads "libjxl_threads >= 0.7.0" jxl/thread_parallel_runner.h JxlThreadParallelRunner
>   enabled libklvanc         && require libklvanc libklvanc/vanc.h klvanc_context_create -lklvanc
>   enabled libkvazaar        && require_pkg_config libkvazaar "kvazaar >= 2.0.0" kvazaar.h kvz_api_get
> -enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_new
> +enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_create
>   
>   if enabled libmfx && enabled libvpl; then
>      die "ERROR: can not use libmfx and libvpl together"
Gyan Doshi Jan. 1, 2024, 10:02 a.m. UTC | #2
On 2024-01-01 09:33 am, Gyan Doshi wrote:
>
>
> On 2023-12-31 01:03 pm, Gyan Doshi wrote:
>> The function lf_db_new was deprecated in lensfun 09dcd3e7ad in 2017
>> in favour of lf_db_create. The AVfilter was adjusted in 8b78eb312d
>> but the configure check wasn't changed.
>>
>> lensfun removed lf_db_new declaration in lf 35c0017593 so configure
>> fails to find lensfun.
>> ---
> This unbreaks use of the lib so plan to push in a few hours.

Pushed as e1c1dc8347f13104bc21e4100fcf4d4dddf5e5d8

Regards,
Gyan
diff mbox series

Patch

diff --git a/configure b/configure
index cd66e42850..9262c1b650 100755
--- a/configure
+++ b/configure
@@ -6776,7 +6776,7 @@  enabled libjxl            && require_pkg_config libjxl "libjxl >= 0.7.0" jxl/dec
                              require_pkg_config libjxl_threads "libjxl_threads >= 0.7.0" jxl/thread_parallel_runner.h JxlThreadParallelRunner
 enabled libklvanc         && require libklvanc libklvanc/vanc.h klvanc_context_create -lklvanc
 enabled libkvazaar        && require_pkg_config libkvazaar "kvazaar >= 2.0.0" kvazaar.h kvz_api_get
-enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_new
+enabled liblensfun        && require_pkg_config liblensfun lensfun lensfun.h lf_db_create
 
 if enabled libmfx && enabled libvpl; then
    die "ERROR: can not use libmfx and libvpl together"