diff mbox series

[FFmpeg-devel,3/8] fftools/ffmpeg_demux: do not set bitexact directly on the decoder

Message ID 20240105164251.28935-3-anton@khirnov.net
State Accepted
Commit 7e33534506086ccd0d0ccd67ebe87cb02384e7c9
Headers show
Series [FFmpeg-devel,1/8] fftools/ffmpeg_demux: replace abort() by av_assert0(0) | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Anton Khirnov Jan. 5, 2024, 4:42 p.m. UTC 
Add it to decoder options instead, to be processed when opening the
decoder. This way it won't be overridden by flags the user might be
setting otherwise.
---
 fftools/ffmpeg_demux.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Sabatini Jan. 6, 2024, 11:24 a.m. UTC | #1 
On date Friday 2024-01-05 17:42:46 +0100, Anton Khirnov wrote:
> Add it to decoder options instead, to be processed when opening the
> decoder. This way it won't be overridden by flags the user might be
> setting otherwise.
> ---
>  fftools/ffmpeg_demux.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
> index 5d07b7153d..cacdc76a71 100644
> --- a/fftools/ffmpeg_demux.c
> +++ b/fftools/ffmpeg_demux.c
> @@ -1156,7 +1156,7 @@ static int ist_add(const OptionsContext *o, Demuxer *d, AVStream *st)
>      }
>  
>      if (o->bitexact)
> -        ist->dec_ctx->flags |= AV_CODEC_FLAG_BITEXACT;
> +        av_dict_set(&ist->decoder_opts, "flags", "+bitexact", AV_DICT_MULTIKEY);

LGTM.
diff mbox series

Patch

diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c
index 5d07b7153d..cacdc76a71 100644
--- a/fftools/ffmpeg_demux.c
+++ b/fftools/ffmpeg_demux.c
@@ -1156,7 +1156,7 @@  static int ist_add(const OptionsContext *o, Demuxer *d, AVStream *st)
     }
 
     if (o->bitexact)
-        ist->dec_ctx->flags |= AV_CODEC_FLAG_BITEXACT;
+        av_dict_set(&ist->decoder_opts, "flags", "+bitexact", AV_DICT_MULTIKEY);
 
     switch (par->codec_type) {
     case AVMEDIA_TYPE_VIDEO: