diff mbox series

[FFmpeg-devel,1/4] avformat/iamfenc: don't write empty packets

Message ID 20240107213100.16205-1-jamrial@gmail.com
State Accepted
Commit 9da0594f1d63be980dd8e8a7f7568a051ea39782
Headers show
Series [FFmpeg-devel,1/4] avformat/iamfenc: don't write empty packets | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

James Almer Jan. 7, 2024, 9:30 p.m. UTC 
And return an error if they are not side data only packets.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/iamfenc.c | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff mbox series

Patch

diff --git a/libavformat/iamfenc.c b/libavformat/iamfenc.c
index 1de416b663..a02f84035a 100644
--- a/libavformat/iamfenc.c
+++ b/libavformat/iamfenc.c
@@ -278,6 +278,16 @@  static int iamf_write_packet(AVFormatContext *s, AVPacket *pkt)
     int dyn_size, type = st->id <= 17 ? st->id + IAMF_OBU_IA_AUDIO_FRAME_ID0 : IAMF_OBU_IA_AUDIO_FRAME;
     int ret;
 
+    if (!pkt->size) {
+        uint8_t *new_extradata = av_packet_get_side_data(pkt, AV_PKT_DATA_NEW_EXTRADATA, NULL);
+
+        if (!new_extradata)
+            return AVERROR_INVALIDDATA;
+
+        // TODO: update FLAC Streaminfo on seekable output
+        return 0;
+    }
+
     if (s->nb_stream_groups && st->id == c->first_stream_id) {
         AVIAMFParamDefinition *mix =
             (AVIAMFParamDefinition *)av_packet_get_side_data(pkt, AV_PKT_DATA_IAMF_MIX_GAIN_PARAM, NULL);