diff mbox series

[FFmpeg-devel] fate/audio: add ADX demux and decode test

Message ID 20240111220156.2123495-1-marth64@proxyid.net
State New
Headers show
Series [FFmpeg-devel] fate/audio: add ADX demux and decode test | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 fail Make fate failed

Commit Message

Marth64 Jan. 11, 2024, 10:01 p.m. UTC
Necessary samples to fate-samples/adx :
https://ufile.io/f/v306q

Samples are re-encodes of luckynight from FATE suite.
d3a67e1d21bbaa7afc8e3bd089545ad44685e0c7a4212a75f7d115b0b8d656eb  luckynight.adx
f994367773da8cadc5a41d7eab680a3f24685211d3564d8a806857cab47bdf25  luckynight.pcm

Signed-off-by: Marth64 <marth64@proxyid.net>
---
 tests/fate/audio.mak | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Paul B Mahol Jan. 12, 2024, 1:10 p.m. UTC | #1
http://coverage.ffmpeg.org/

*Is this really needed? Does it improves coverage at all?*

On Thu, Jan 11, 2024 at 11:02 PM Marth64 <marth64@proxyid.net> wrote:

> Necessary samples to fate-samples/adx :
> https://ufile.io/f/v306q
>
> Samples are re-encodes of luckynight from FATE suite.
> d3a67e1d21bbaa7afc8e3bd089545ad44685e0c7a4212a75f7d115b0b8d656eb
> luckynight.adx
> f994367773da8cadc5a41d7eab680a3f24685211d3564d8a806857cab47bdf25
> luckynight.pcm
>
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
>  tests/fate/audio.mak | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak
> index 65317c8d45..1c0f48ae0d 100644
> --- a/tests/fate/audio.mak
> +++ b/tests/fate/audio.mak
> @@ -1,3 +1,8 @@
> +FATE_SAMPLES_AUDIO-$(call DEMDEC, ADX, ADPCM_ADX) += fate-adx
> +fate-adx: CMD = pcm -i $(TARGET_SAMPLES)/adx/luckynight.adx
> +fate-adx: CMP = oneoff
> +fate-adx: REF = $(SAMPLES)/adx/luckynight.pcm
> +
>  FATE_SAMPLES_AUDIO-$(call TRANSCODE, APTX, APTX, WAV_DEMUXER
> PCM_S16LE_DECODER ARESAMPLE_FILTER) += fate-aptx
>  fate-aptx: CMD = transcode wav
> $(TARGET_SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav aptx "-af
> aresample -c aptx" "-af aresample -c:a pcm_s16le -t 0.25" "" "" "-f aptx
> -sample_rate 44100"
>
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Marth64 Jan. 12, 2024, 3:26 p.m. UTC | #2
I didn’t know about that website until now. Thanks

On Fri, Jan 12, 2024 at 07:10 Paul B Mahol <onemda@gmail.com> wrote:

> http://coverage.ffmpeg.org/
>
> *Is this really needed? Does it improves coverage at all?*
>
> On Thu, Jan 11, 2024 at 11:02 PM Marth64 <marth64@proxyid.net> wrote:
>
>> Necessary samples to fate-samples/adx :
>> https://ufile.io/f/v306q
>>
>> Samples are re-encodes of luckynight from FATE suite.
>> d3a67e1d21bbaa7afc8e3bd089545ad44685e0c7a4212a75f7d115b0b8d656eb
>> luckynight.adx
>> f994367773da8cadc5a41d7eab680a3f24685211d3564d8a806857cab47bdf25
>> luckynight.pcm
>>
>> Signed-off-by: Marth64 <marth64@proxyid.net>
>> ---
>>  tests/fate/audio.mak | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak
>> index 65317c8d45..1c0f48ae0d 100644
>> --- a/tests/fate/audio.mak
>> +++ b/tests/fate/audio.mak
>> @@ -1,3 +1,8 @@
>> +FATE_SAMPLES_AUDIO-$(call DEMDEC, ADX, ADPCM_ADX) += fate-adx
>> +fate-adx: CMD = pcm -i $(TARGET_SAMPLES)/adx/luckynight.adx
>> +fate-adx: CMP = oneoff
>> +fate-adx: REF = $(SAMPLES)/adx/luckynight.pcm
>> +
>>  FATE_SAMPLES_AUDIO-$(call TRANSCODE, APTX, APTX, WAV_DEMUXER
>> PCM_S16LE_DECODER ARESAMPLE_FILTER) += fate-aptx
>>  fate-aptx: CMD = transcode wav
>> $(TARGET_SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav aptx "-af
>> aresample -c aptx" "-af aresample -c:a pcm_s16le -t 0.25" "" "" "-f aptx
>> -sample_rate 44100"
>>
>> --
>> 2.34.1
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
>
Marth64 Jan. 12, 2024, 6:29 p.m. UTC | #3
It’s not a critical work. But for future contribution I will reference that
website to see what makes more sense to do. Thank you for letting me know!

On Fri, Jan 12, 2024 at 09:26 Marth64 <marth64@proxyid.net> wrote:

> I didn’t know about that website until now. Thanks
>
> On Fri, Jan 12, 2024 at 07:10 Paul B Mahol <onemda@gmail.com> wrote:
>
>> http://coverage.ffmpeg.org/
>>
>> *Is this really needed? Does it improves coverage at all?*
>>
>> On Thu, Jan 11, 2024 at 11:02 PM Marth64 <marth64@proxyid.net> wrote:
>>
>>> Necessary samples to fate-samples/adx :
>>> https://ufile.io/f/v306q
>>>
>>> Samples are re-encodes of luckynight from FATE suite.
>>> d3a67e1d21bbaa7afc8e3bd089545ad44685e0c7a4212a75f7d115b0b8d656eb
>>> luckynight.adx
>>> f994367773da8cadc5a41d7eab680a3f24685211d3564d8a806857cab47bdf25
>>> luckynight.pcm
>>>
>>> Signed-off-by: Marth64 <marth64@proxyid.net>
>>> ---
>>>  tests/fate/audio.mak | 5 +++++
>>>  1 file changed, 5 insertions(+)
>>>
>>> diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak
>>> index 65317c8d45..1c0f48ae0d 100644
>>> --- a/tests/fate/audio.mak
>>> +++ b/tests/fate/audio.mak
>>> @@ -1,3 +1,8 @@
>>> +FATE_SAMPLES_AUDIO-$(call DEMDEC, ADX, ADPCM_ADX) += fate-adx
>>> +fate-adx: CMD = pcm -i $(TARGET_SAMPLES)/adx/luckynight.adx
>>> +fate-adx: CMP = oneoff
>>> +fate-adx: REF = $(SAMPLES)/adx/luckynight.pcm
>>> +
>>>  FATE_SAMPLES_AUDIO-$(call TRANSCODE, APTX, APTX, WAV_DEMUXER
>>> PCM_S16LE_DECODER ARESAMPLE_FILTER) += fate-aptx
>>>  fate-aptx: CMD = transcode wav
>>> $(TARGET_SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav aptx "-af
>>> aresample -c aptx" "-af aresample -c:a pcm_s16le -t 0.25" "" "" "-f aptx
>>> -sample_rate 44100"
>>>
>>> --
>>> 2.34.1
>>>
>>> _______________________________________________
>>> ffmpeg-devel mailing list
>>> ffmpeg-devel@ffmpeg.org
>>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>>
>>> To unsubscribe, visit link above, or email
>>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>>
>>
Stefano Sabatini Jan. 14, 2024, 1:53 p.m. UTC | #4
On date Thursday 2024-01-11 16:01:57 -0600, Marth64 wrote:
> Necessary samples to fate-samples/adx :
> https://ufile.io/f/v306q
> 
> Samples are re-encodes of luckynight from FATE suite.
> d3a67e1d21bbaa7afc8e3bd089545ad44685e0c7a4212a75f7d115b0b8d656eb  luckynight.adx
> f994367773da8cadc5a41d7eab680a3f24685211d3564d8a806857cab47bdf25  luckynight.pcm
> 
> Signed-off-by: Marth64 <marth64@proxyid.net>
> ---
>  tests/fate/audio.mak | 5 +++++
>  1 file changed, 5 insertions(+)

Not sure if this needs a fate upload to be committed.
diff mbox series

Patch

diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak
index 65317c8d45..1c0f48ae0d 100644
--- a/tests/fate/audio.mak
+++ b/tests/fate/audio.mak
@@ -1,3 +1,8 @@ 
+FATE_SAMPLES_AUDIO-$(call DEMDEC, ADX, ADPCM_ADX) += fate-adx
+fate-adx: CMD = pcm -i $(TARGET_SAMPLES)/adx/luckynight.adx
+fate-adx: CMP = oneoff
+fate-adx: REF = $(SAMPLES)/adx/luckynight.pcm
+
 FATE_SAMPLES_AUDIO-$(call TRANSCODE, APTX, APTX, WAV_DEMUXER PCM_S16LE_DECODER ARESAMPLE_FILTER) += fate-aptx
 fate-aptx: CMD = transcode wav $(TARGET_SAMPLES)/audio-reference/luckynight_2ch_44kHz_s16.wav aptx "-af aresample -c aptx" "-af aresample -c:a pcm_s16le -t 0.25" "" "" "-f aptx -sample_rate 44100"