| Message ID | 20240204184132.876492-1-marth64@proxyid.net |
|---|---|
| State | Accepted |
| Commit | 97fb84d74e9086cbed135486dca70ca8c569449c |
| Headers | show |
| Series | [FFmpeg-devel,v2] doc/formats: clarify meaning of igndts as per definition in avformat.h | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On date Sunday 2024-02-04 12:41:33 -0600, Marth64 wrote: > This updates the documentation to be more clear about igndts, > as per feedback in December variant of this patch (thank you) > > Signed-off-by: Marth64 <marth64@proxyid.net> > --- > doc/formats.texi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/doc/formats.texi b/doc/formats.texi > index 640b23b790..69fc1457a4 100644 > --- a/doc/formats.texi > +++ b/doc/formats.texi > @@ -46,7 +46,8 @@ Enable fast, but inaccurate seeks for some formats. > @item genpts > Generate missing PTS if DTS is present. > @item igndts > -Ignore DTS if PTS is set. Inert when nofillin is set. > +Ignore DTS if PTS is also set. In case the PTS is set, the DTS value > +is set to NOPTS. This is ignored when the @code{nofillin} flag is set. LGTM, I'll apply in a few days if I see no comments, thanks.
On date Monday 2024-02-05 01:27:07 +0100, Stefano Sabatini wrote: > On date Sunday 2024-02-04 12:41:33 -0600, Marth64 wrote: > > This updates the documentation to be more clear about igndts, > > as per feedback in December variant of this patch (thank you) > > > > Signed-off-by: Marth64 <marth64@proxyid.net> > > --- > > doc/formats.texi | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/doc/formats.texi b/doc/formats.texi > > index 640b23b790..69fc1457a4 100644 > > --- a/doc/formats.texi > > +++ b/doc/formats.texi > > @@ -46,7 +46,8 @@ Enable fast, but inaccurate seeks for some formats. > > @item genpts > > Generate missing PTS if DTS is present. > > @item igndts > > -Ignore DTS if PTS is set. Inert when nofillin is set. > > +Ignore DTS if PTS is also set. In case the PTS is set, the DTS value > > +is set to NOPTS. This is ignored when the @code{nofillin} flag is set. > > LGTM, I'll apply in a few days if I see no comments, thanks. Applied.
Glad to see this one fixed. Thank you! On Tue, Feb 6, 2024 at 5:58 PM Stefano Sabatini <stefasab@gmail.com> wrote: > On date Monday 2024-02-05 01:27:07 +0100, Stefano Sabatini wrote: > > On date Sunday 2024-02-04 12:41:33 -0600, Marth64 wrote: > > > This updates the documentation to be more clear about igndts, > > > as per feedback in December variant of this patch (thank you) > > > > > > Signed-off-by: Marth64 <marth64@proxyid.net> > > > --- > > > doc/formats.texi | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/doc/formats.texi b/doc/formats.texi > > > index 640b23b790..69fc1457a4 100644 > > > --- a/doc/formats.texi > > > +++ b/doc/formats.texi > > > @@ -46,7 +46,8 @@ Enable fast, but inaccurate seeks for some formats. > > > @item genpts > > > Generate missing PTS if DTS is present. > > > @item igndts > > > -Ignore DTS if PTS is set. Inert when nofillin is set. > > > +Ignore DTS if PTS is also set. In case the PTS is set, the DTS value > > > +is set to NOPTS. This is ignored when the @code{nofillin} flag is set. > > > > LGTM, I'll apply in a few days if I see no comments, thanks. > > Applied. >
diff --git a/doc/formats.texi b/doc/formats.texi index 640b23b790..69fc1457a4 100644 --- a/doc/formats.texi +++ b/doc/formats.texi @@ -46,7 +46,8 @@ Enable fast, but inaccurate seeks for some formats. @item genpts Generate missing PTS if DTS is present. @item igndts -Ignore DTS if PTS is set. Inert when nofillin is set. +Ignore DTS if PTS is also set. In case the PTS is set, the DTS value +is set to NOPTS. This is ignored when the @code{nofillin} flag is set. @item ignidx Ignore index. @item nobuffer
This updates the documentation to be more clear about igndts, as per feedback in December variant of this patch (thank you) Signed-off-by: Marth64 <marth64@proxyid.net> --- doc/formats.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)