diff mbox series

[FFmpeg-devel] avcodec/avcodec: don't print coded dimensions if not set

Message ID 20240210173941.61540-1-jamrial@gmail.com
State Accepted
Commit eb5b4e60c9c2ad701c99f5ab2c606a66b3119341
Headers show
Series [FFmpeg-devel] avcodec/avcodec: don't print coded dimensions if not set | expand

Checks

Context Check Description
andriy/commit_msg_x86 warning Please wrap lines in the body of the commit message between 60 and 72 characters.
yinshiyou/commit_msg_loongarch64 warning Please wrap lines in the body of the commit message between 60 and 72 characters.
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

James Almer Feb. 10, 2024, 5:39 p.m. UTC
The avctx passed to avcodec_string() may have unset coded dimensions, as is
the case when called by av_dump_format() where the streams had all the needed
information at the container level, and as such no frames were decoded internally.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavcodec/avcodec.c | 1 +
 1 file changed, 1 insertion(+)

Comments

James Almer Feb. 13, 2024, 1:42 p.m. UTC | #1
On 2/10/2024 2:39 PM, James Almer wrote:
> The avctx passed to avcodec_string() may have unset coded dimensions, as is
> the case when called by av_dump_format() where the streams had all the needed
> information at the container level, and as such no frames were decoded internally.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>   libavcodec/avcodec.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c
> index b6d27ada21..a13b781996 100644
> --- a/libavcodec/avcodec.c
> +++ b/libavcodec/avcodec.c
> @@ -625,6 +625,7 @@ void avcodec_string(char *buf, int buf_size, AVCodecContext *enc, int encode)
>                          enc->width, enc->height);
>   
>               if (av_log_get_level() >= AV_LOG_VERBOSE &&
> +                enc->coded_width && enc->coded_height &&
>                   (enc->width != enc->coded_width ||
>                    enc->height != enc->coded_height))
>                   av_bprintf(&bprint, " (%dx%d)",

Will apply.
diff mbox series

Patch

diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c
index b6d27ada21..a13b781996 100644
--- a/libavcodec/avcodec.c
+++ b/libavcodec/avcodec.c
@@ -625,6 +625,7 @@  void avcodec_string(char *buf, int buf_size, AVCodecContext *enc, int encode)
                        enc->width, enc->height);
 
             if (av_log_get_level() >= AV_LOG_VERBOSE &&
+                enc->coded_width && enc->coded_height &&
                 (enc->width != enc->coded_width ||
                  enc->height != enc->coded_height))
                 av_bprintf(&bprint, " (%dx%d)",