diff mbox series

[FFmpeg-devel] checkasm: Add a "run-checkasm" make target

Message ID 20240214134802.43623-1-martin@martin.st
State Accepted
Headers show
Series [FFmpeg-devel] checkasm: Add a "run-checkasm" make target | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Martin Storsjö Feb. 14, 2024, 1:48 p.m. UTC 
Contrary to the existing "fate-checkasm", this always prints the
tool output, and runs all tests at once instead of splitting it up
per target group. This is more useful when the user expects to
look directly at the tool output, instead of being part of a full
fate run.

(On failure with the regular "make fate-checkasm" targets, none of
the tool output is printed, but stored in files. If run with reporting
set up to the FATE website, the individual failures are uploaded there,
but if it is run in some sort of other CI setup, the intermediate files
might not be available afterwards for inspection.)
---
 tests/checkasm/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Martin Storsjö Feb. 21, 2024, 8:55 a.m. UTC | #1 
On Wed, 14 Feb 2024, Martin Storsjö wrote:

> Contrary to the existing "fate-checkasm", this always prints the
> tool output, and runs all tests at once instead of splitting it up
> per target group. This is more useful when the user expects to
> look directly at the tool output, instead of being part of a full
> fate run.
>
> (On failure with the regular "make fate-checkasm" targets, none of
> the tool output is printed, but stored in files. If run with reporting
> set up to the FATE website, the individual failures are uploaded there,
> but if it is run in some sort of other CI setup, the intermediate files
> might not be available afterwards for inspection.)
> ---
> tests/checkasm/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile
> index 3562acb2b2..3af42a679b 100644
> --- a/tests/checkasm/Makefile
> +++ b/tests/checkasm/Makefile
> @@ -91,6 +91,10 @@ CHECKASM := tests/checkasm/checkasm$(EXESUF)
> $(CHECKASM): $(CHECKASMOBJS) $(FF_STATIC_DEP_LIBS)
> 	$(LD) $(LDFLAGS) $(LDEXEFLAGS) $(LD_O) $(CHECKASMOBJS) $(FF_STATIC_DEP_LIBS) $(EXTRALIBS-avcodec) $(EXTRALIBS-avfilter) $(EXTRALIBS-avformat) $(EXTRALIBS-avutil) $(EXTRALIBS-swresample) $(EXTRALIBS)
>
> +run-checkasm: $(CHECKASM)
> +run-checkasm:
> +	$(TARGET_EXEC) $(TARGET_PATH)/$(CHECKASM)

I've amended this locally with a $(Q) at the start, to silence the 
executed command, unless executed with V=1.

I'll push this patch later today if there aren't any objections.

// Martin
diff mbox series

Patch

diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile
index 3562acb2b2..3af42a679b 100644
--- a/tests/checkasm/Makefile
+++ b/tests/checkasm/Makefile
@@ -91,6 +91,10 @@  CHECKASM := tests/checkasm/checkasm$(EXESUF)
 $(CHECKASM): $(CHECKASMOBJS) $(FF_STATIC_DEP_LIBS)
 	$(LD) $(LDFLAGS) $(LDEXEFLAGS) $(LD_O) $(CHECKASMOBJS) $(FF_STATIC_DEP_LIBS) $(EXTRALIBS-avcodec) $(EXTRALIBS-avfilter) $(EXTRALIBS-avformat) $(EXTRALIBS-avutil) $(EXTRALIBS-swresample) $(EXTRALIBS)
 
+run-checkasm: $(CHECKASM)
+run-checkasm:
+	$(TARGET_EXEC) $(TARGET_PATH)/$(CHECKASM)
+
 checkasm: $(CHECKASM)
 
 testclean:: checkasmclean