diff mbox series

[FFmpeg-devel] fftools/cmdutils: remove harmful variable shadowing

Message ID 20240221155813.27298-1-anton@khirnov.net
State Accepted
Commit 29e1b9d90c23c2c1e377dfec9960a232445acd33
Headers show
Series [FFmpeg-devel] fftools/cmdutils: remove harmful variable shadowing | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Anton Khirnov Feb. 21, 2024, 3:58 p.m. UTC 
It causes write_option() to return 0 when calling func_arg() fails.
---
 fftools/cmdutils.c | 2 --
 1 file changed, 2 deletions(-)
diff mbox series

Patch

diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index 5e181a0d85..3d613a4018 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -339,8 +339,6 @@  static int write_option(void *optctx, const OptionDef *po, const char *opt,
 
         *(double *)dst = num;
     } else {
-        int ret;
-
         av_assert0(po->type == OPT_TYPE_FUNC && po->u.func_arg);
 
         ret = po->u.func_arg(optctx, opt, arg);