| Message ID | 20240306234837.19083-1-gseanmcg@gmail.com |
|---|---|
| State | Accepted |
| Commit | f63a87629e5229119d22c95533f14ec89b97e623 |
| Headers | show |
| Series | [FFmpeg-devel] fate: fix sub2video_{basic, time_limited} on big-endian targets | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Wed, Mar 6, 2024, 18:48 Sean McGovern <gseanmcg@gmail.com> wrote: > The reference file uses BGRA pixel format, so request it here. > --- > tests/fate/ffmpeg.mak | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak > index 669c878c7f..77e93693b9 100644 > --- a/tests/fate/ffmpeg.mak > +++ b/tests/fate/ffmpeg.mak > @@ -62,6 +62,7 @@ fate-sub2video: CMD = framecrc -auto_conversion_filters \ > FATE_SAMPLES_FFMPEG-$(call FRAMECRC, VOBSUB, DVDSUB, SCALE_FILTER) += > fate-sub2video_basic > fate-sub2video_basic: CMD = framecrc -auto_conversion_filters \ > -i $(TARGET_SAMPLES)/sub/vobsub.idx \ > + -pix_fmt bgra \ > -fps_mode passthrough -copyts \ > -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \ > -c:v rawvideo -threads 1 > @@ -71,6 +72,7 @@ fate-sub2video_basic: CMD = framecrc > -auto_conversion_filters \ > FATE_SAMPLES_FFMPEG-$(call FRAMECRC, SUP, PGSSUB, SCALE_FILTER > RAWVIDEO_ENCODER) += fate-sub2video_time_limited > fate-sub2video_time_limited: CMD = framecrc -auto_conversion_filters \ > -i $(TARGET_SAMPLES)/sub/pgs_sub.sup \ > + -pix_fmt bgra \ > -fps_mode passthrough -copyts \ > -t 15 \ > -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \ > -- > 2.39.2 > Ping review, if someone has some cycle. -- Sean McGovern
Hi, On Fri, Mar 8, 2024, 10:11 Sean McGovern <gseanmcg@gmail.com> wrote: > On Wed, Mar 6, 2024, 18:48 Sean McGovern <gseanmcg@gmail.com> wrote: > >> The reference file uses BGRA pixel format, so request it here. >> --- >> tests/fate/ffmpeg.mak | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak >> index 669c878c7f..77e93693b9 100644 >> --- a/tests/fate/ffmpeg.mak >> +++ b/tests/fate/ffmpeg.mak >> @@ -62,6 +62,7 @@ fate-sub2video: CMD = framecrc -auto_conversion_filters >> \ >> FATE_SAMPLES_FFMPEG-$(call FRAMECRC, VOBSUB, DVDSUB, SCALE_FILTER) += >> fate-sub2video_basic >> fate-sub2video_basic: CMD = framecrc -auto_conversion_filters \ >> -i $(TARGET_SAMPLES)/sub/vobsub.idx \ >> + -pix_fmt bgra \ >> -fps_mode passthrough -copyts \ >> -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \ >> -c:v rawvideo -threads 1 >> @@ -71,6 +72,7 @@ fate-sub2video_basic: CMD = framecrc >> -auto_conversion_filters \ >> FATE_SAMPLES_FFMPEG-$(call FRAMECRC, SUP, PGSSUB, SCALE_FILTER >> RAWVIDEO_ENCODER) += fate-sub2video_time_limited >> fate-sub2video_time_limited: CMD = framecrc -auto_conversion_filters \ >> -i $(TARGET_SAMPLES)/sub/pgs_sub.sup \ >> + -pix_fmt bgra \ >> -fps_mode passthrough -copyts \ >> -t 15 \ >> -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \ >> -- >> 2.39.2 > > Ping review again, I was rather hoping this could make it into 7.0. -- Sean McGovern
diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak index 669c878c7f..77e93693b9 100644 --- a/tests/fate/ffmpeg.mak +++ b/tests/fate/ffmpeg.mak @@ -62,6 +62,7 @@ fate-sub2video: CMD = framecrc -auto_conversion_filters \ FATE_SAMPLES_FFMPEG-$(call FRAMECRC, VOBSUB, DVDSUB, SCALE_FILTER) += fate-sub2video_basic fate-sub2video_basic: CMD = framecrc -auto_conversion_filters \ -i $(TARGET_SAMPLES)/sub/vobsub.idx \ + -pix_fmt bgra \ -fps_mode passthrough -copyts \ -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \ -c:v rawvideo -threads 1 @@ -71,6 +72,7 @@ fate-sub2video_basic: CMD = framecrc -auto_conversion_filters \ FATE_SAMPLES_FFMPEG-$(call FRAMECRC, SUP, PGSSUB, SCALE_FILTER RAWVIDEO_ENCODER) += fate-sub2video_time_limited fate-sub2video_time_limited: CMD = framecrc -auto_conversion_filters \ -i $(TARGET_SAMPLES)/sub/pgs_sub.sup \ + -pix_fmt bgra \ -fps_mode passthrough -copyts \ -t 15 \ -filter_complex "sws_flags=+accurate_rnd+bitexact\;[0:s:0]scale" \