diff mbox series

[FFmpeg-devel,v1,2/2] lavc/vvc_ps: Correct NoOutputBeforeRecoveryFlag of IDR

Message ID 20240308005531.1757078-2-fei.w.wang@intel.com
State New
Headers show
Series [FFmpeg-devel,v1,1/2] lavc/vvcdec: Add missed chroma sampling factor for crop offset | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Wang, Fei W March 8, 2024, 12:55 a.m. UTC 
From: Fei Wang <fei.w.wang@intel.com>

Signed-off-by: Fei Wang <fei.w.wang@intel.com>
---
 libavcodec/vvc/vvc_ps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Nuo Mi March 9, 2024, 11:59 a.m. UTC | #1 
Hi Fei,
Thank you fei,
Better provide more comments
Is there any clip fail for this?

On Fri, Mar 8, 2024 at 8:55 AM <fei.w.wang-at-intel.com@ffmpeg.org> wrote:

> From: Fei Wang <fei.w.wang@intel.com>
>
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
>  libavcodec/vvc/vvc_ps.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/vvc/vvc_ps.c b/libavcodec/vvc/vvc_ps.c
> index e6e46d2039..7972803da6 100644
> --- a/libavcodec/vvc/vvc_ps.c
> +++ b/libavcodec/vvc/vvc_ps.c
> @@ -742,7 +742,7 @@ static int decode_frame_ps(VVCFrameParamSets *fps,
> const VVCParamSets *ps,
>  static void decode_recovery_flag(VVCContext *s)
>  {
>      if (IS_IDR(s))
> -        s->no_output_before_recovery_flag = 0;
> +        s->no_output_before_recovery_flag = 1;
>      else if (IS_CRA(s) || IS_GDR(s))
>          s->no_output_before_recovery_flag = s->last_eos;
>  }
> --
> 2.25.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Wang, Fei W March 11, 2024, 2:03 a.m. UTC | #2 
On Sat, 2024-03-09 at 19:59 +0800, Nuo Mi wrote:
Hi Fei,
Thank you fei,
Better provide more comments

Added in V2.

Is there any clip fail for this?

No, just notice the defect when I check why recovering frames been outputted in GDR_D_ERICSSON_1.bit.

Thanks
Fei


On Fri, Mar 8, 2024 at 8:55 AM <fei.w.wang-at-intel.com@ffmpeg.org<mailto:fei.w.wang-at-intel.com@ffmpeg.org>> wrote:
From: Fei Wang <fei.w.wang@intel.com<mailto:fei.w.wang@intel.com>>

Signed-off-by: Fei Wang <fei.w.wang@intel.com<mailto:fei.w.wang@intel.com>>
---
 libavcodec/vvc/vvc_ps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/vvc/vvc_ps.c b/libavcodec/vvc/vvc_ps.c
index e6e46d2039..7972803da6 100644
--- a/libavcodec/vvc/vvc_ps.c
+++ b/libavcodec/vvc/vvc_ps.c
@@ -742,7 +742,7 @@ static int decode_frame_ps(VVCFrameParamSets *fps, const VVCParamSets *ps,
 static void decode_recovery_flag(VVCContext *s)
 {
     if (IS_IDR(s))
-        s->no_output_before_recovery_flag = 0;
+        s->no_output_before_recovery_flag = 1;
     else if (IS_CRA(s) || IS_GDR(s))
         s->no_output_before_recovery_flag = s->last_eos;
 }
diff mbox series

Patch

diff --git a/libavcodec/vvc/vvc_ps.c b/libavcodec/vvc/vvc_ps.c
index e6e46d2039..7972803da6 100644
--- a/libavcodec/vvc/vvc_ps.c
+++ b/libavcodec/vvc/vvc_ps.c
@@ -742,7 +742,7 @@  static int decode_frame_ps(VVCFrameParamSets *fps, const VVCParamSets *ps,
 static void decode_recovery_flag(VVCContext *s)
 {
     if (IS_IDR(s))
-        s->no_output_before_recovery_flag = 0;
+        s->no_output_before_recovery_flag = 1;
     else if (IS_CRA(s) || IS_GDR(s))
         s->no_output_before_recovery_flag = s->last_eos;
 }