diff mbox series

[FFmpeg-devel,1/2] avfilter: mark scale2ref as supporting dynamic sizes

Message ID 20240313122425.92457-1-ffmpeg@haasn.xyz
State New
Headers show
Series [FFmpeg-devel,1/2] avfilter: mark scale2ref as supporting dynamic sizes | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Niklas Haas March 13, 2024, 12:24 p.m. UTC
From: Niklas Haas <git@haasn.dev>

Analogous to the "scale" filter, which this is practically identical
with.
---
 libavfilter/avfilter.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Gyan Doshi March 13, 2024, 1:14 p.m. UTC | #1
On 2024-03-13 05:54 pm, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
>
> Analogous to the "scale" filter, which this is practically identical
> with.
> ---
>   libavfilter/avfilter.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
> index 831871de90b..dcad4d55292 100644
> --- a/libavfilter/avfilter.c
> +++ b/libavfilter/avfilter.c
> @@ -1027,7 +1027,8 @@ int ff_filter_frame(AVFilterLink *link, AVFrame *frame)
>               strcmp(link->dst->filter->name, "format") &&
>               strcmp(link->dst->filter->name, "idet") &&
>               strcmp(link->dst->filter->name, "null") &&
> -            strcmp(link->dst->filter->name, "scale")) {
> +            strcmp(link->dst->filter->name, "scale") &&
> +            strcmp(link->dst->filter->name, "scale2ref")) {
>               av_assert1(frame->format        == link->format);
>               av_assert1(frame->width         == link->w);
>               av_assert1(frame->height        == link->h);

LGTM.

Regards,
Gyan
Michael Niedermayer March 16, 2024, 11:26 p.m. UTC | #2
On Wed, Mar 13, 2024 at 01:24:24PM +0100, Niklas Haas wrote:
> From: Niklas Haas <git@haasn.dev>
> 
> Analogous to the "scale" filter, which this is practically identical
> with.
> ---
>  libavfilter/avfilter.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
> index 831871de90b..dcad4d55292 100644
> --- a/libavfilter/avfilter.c
> +++ b/libavfilter/avfilter.c
> @@ -1027,7 +1027,8 @@ int ff_filter_frame(AVFilterLink *link, AVFrame *frame)
>              strcmp(link->dst->filter->name, "format") &&
>              strcmp(link->dst->filter->name, "idet") &&
>              strcmp(link->dst->filter->name, "null") &&
> -            strcmp(link->dst->filter->name, "scale")) {
> +            strcmp(link->dst->filter->name, "scale") &&
> +            strcmp(link->dst->filter->name, "scale2ref")) {
>              av_assert1(frame->format        == link->format);
>              av_assert1(frame->width         == link->w);
>              av_assert1(frame->height        == link->h);

LGTM

[...]
diff mbox series

Patch

diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index 831871de90b..dcad4d55292 100644
--- a/libavfilter/avfilter.c
+++ b/libavfilter/avfilter.c
@@ -1027,7 +1027,8 @@  int ff_filter_frame(AVFilterLink *link, AVFrame *frame)
             strcmp(link->dst->filter->name, "format") &&
             strcmp(link->dst->filter->name, "idet") &&
             strcmp(link->dst->filter->name, "null") &&
-            strcmp(link->dst->filter->name, "scale")) {
+            strcmp(link->dst->filter->name, "scale") &&
+            strcmp(link->dst->filter->name, "scale2ref")) {
             av_assert1(frame->format        == link->format);
             av_assert1(frame->width         == link->w);
             av_assert1(frame->height        == link->h);