diff mbox series

[FFmpeg-devel,3/3] avutil/hwcontext_d3d11va: add logging to dxgi debug interfaces

Message ID 20240314212633.2736-3-timo@rothenpieler.org
State Accepted
Commit 030f4925b8bef8c9964dabec9e93266e3425b34d
Headers show
Series [FFmpeg-devel,1/3] avutil/hwcontext_d3d11va: remove check for d3d11 debug layer dll | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Timo Rothenpieler March 14, 2024, 9:26 p.m. UTC 
---
 libavutil/hwcontext_d3d11va.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Timo Rothenpieler March 17, 2024, 3:11 p.m. UTC | #1 
On 14.03.2024 22:26, Timo Rothenpieler wrote:
> ---
>   libavutil/hwcontext_d3d11va.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c
> index 1b96c38d25..e30c8fc238 100644
> --- a/libavutil/hwcontext_d3d11va.c
> +++ b/libavutil/hwcontext_d3d11va.c
> @@ -685,9 +685,17 @@ static int d3d11va_device_create(AVHWDeviceContext *ctx, const char *device,
>               if (pf_DXGIGetDebugInterface) {
>                   IDXGIDebug *dxgi_debug = NULL;
>                   hr = pf_DXGIGetDebugInterface(&IID_IDXGIDebug, (void**)&dxgi_debug);
> -                if (SUCCEEDED(hr) && dxgi_debug)
> +                if (SUCCEEDED(hr) && dxgi_debug) {
>                       IDXGIDebug_ReportLiveObjects(dxgi_debug, DXGI_DEBUG_ALL, DXGI_DEBUG_RLO_ALL);
> +                    av_log(ctx, AV_LOG_INFO, "Enabled dxgi debugging.\n");
> +                } else {
> +                    av_log(ctx, AV_LOG_WARNING, "Failed enabling dxgi debugging.\n");
> +                }
> +            } else {
> +                av_log(ctx, AV_LOG_WARNING, "Failed getting dxgi debug interface.\n");
>               }
> +        } else {
> +            av_log(ctx, AV_LOG_WARNING, "Failed loading dxgi debug library.\n");
>           }
>       }
>   #endif

will apply series soon if nobody objects
Timo Rothenpieler March 18, 2024, 12:33 p.m. UTC | #2 
applied
diff mbox series

Patch

diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c
index 1b96c38d25..e30c8fc238 100644
--- a/libavutil/hwcontext_d3d11va.c
+++ b/libavutil/hwcontext_d3d11va.c
@@ -685,9 +685,17 @@  static int d3d11va_device_create(AVHWDeviceContext *ctx, const char *device,
             if (pf_DXGIGetDebugInterface) {
                 IDXGIDebug *dxgi_debug = NULL;
                 hr = pf_DXGIGetDebugInterface(&IID_IDXGIDebug, (void**)&dxgi_debug);
-                if (SUCCEEDED(hr) && dxgi_debug)
+                if (SUCCEEDED(hr) && dxgi_debug) {
                     IDXGIDebug_ReportLiveObjects(dxgi_debug, DXGI_DEBUG_ALL, DXGI_DEBUG_RLO_ALL);
+                    av_log(ctx, AV_LOG_INFO, "Enabled dxgi debugging.\n");
+                } else {
+                    av_log(ctx, AV_LOG_WARNING, "Failed enabling dxgi debugging.\n");
+                }
+            } else {
+                av_log(ctx, AV_LOG_WARNING, "Failed getting dxgi debug interface.\n");
             }
+        } else {
+            av_log(ctx, AV_LOG_WARNING, "Failed loading dxgi debug library.\n");
         }
     }
 #endif