diff mbox series

[FFmpeg-devel,2/2] configure: check for C17 by default

Message ID 20240319185818.25400-2-jamrial@gmail.com
State New
Headers show
Series [FFmpeg-devel,1/2] configure: make the C and C++ standard settable | expand

Checks

Context Check Description
andriy/configure_x86 warning Failed to run configure
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

James Almer March 19, 2024, 6:58 p.m. UTC 
Signed-off-by: James Almer <jamrial@gmail.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer March 19, 2024, 9:21 p.m. UTC | #1 
On Tue, Mar 19, 2024 at 03:58:18PM -0300, James Almer wrote:
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index b10d081549..a9a9a65ca2 100755
> --- a/configure
> +++ b/configure
> @@ -4012,7 +4012,7 @@ mandir_default='${prefix}/share/man'
>  # toolchain
>  ar_default="ar"
>  cc_default="gcc"
> -stdc_default="c11"
> +stdc_default="c17"
>  stdcxx_default="c++11"
>  cxx_default="g++"
>  host_cc_default="gcc"

That breaks build here

[...]
Michael Niedermayer March 19, 2024, 9:31 p.m. UTC | #2 
On Tue, Mar 19, 2024 at 10:21:52PM +0100, Michael Niedermayer wrote:
> On Tue, Mar 19, 2024 at 03:58:18PM -0300, James Almer wrote:
> > Signed-off-by: James Almer <jamrial@gmail.com>
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index b10d081549..a9a9a65ca2 100755
> > --- a/configure
> > +++ b/configure
> > @@ -4012,7 +4012,7 @@ mandir_default='${prefix}/share/man'
> >  # toolchain
> >  ar_default="ar"
> >  cc_default="gcc"
> > -stdc_default="c11"
> > +stdc_default="c17"
> >  stdcxx_default="c++11"
> >  cxx_default="g++"
> >  host_cc_default="gcc"
> 
> That breaks build here

also i suspect this will break various fate clients


[...]
diff mbox series

Patch

diff --git a/configure b/configure
index b10d081549..a9a9a65ca2 100755
--- a/configure
+++ b/configure
@@ -4012,7 +4012,7 @@  mandir_default='${prefix}/share/man'
 # toolchain
 ar_default="ar"
 cc_default="gcc"
-stdc_default="c11"
+stdc_default="c17"
 stdcxx_default="c++11"
 cxx_default="g++"
 host_cc_default="gcc"