| Message ID | 20240324022436.1419425-1-marth64@proxyid.net |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] avformat/dvdvideodec: add explicit inttypes.h include | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
On 3/23/24 22:24, Marth64 wrote: > Since log statements printing int64 were made portable in > 4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include > inttypes.h explicitly (as it is unclear where PRId64 and > such are coming from now). > > Reported-by: Traneptora > Signed-off-by: Marth64 <marth64@proxyid.net> > --- > libavformat/dvdvideodec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c > index 761ac97ec6..959b267e69 100644 > --- a/libavformat/dvdvideodec.c > +++ b/libavformat/dvdvideodec.c > @@ -30,6 +30,7 @@ > * 7) Close the dvdnav VM, and free dvdread's IFO structures > */ > > +#include <inttypes.h> > #include <dvdnav/dvdnav.h> > #include <dvdread/dvd_reader.h> > #include <dvdread/ifo_read.h> I would add a space between the inttypes.h include and the dvdread include because inttypes is a standard C library and the others are an external library. If you don't want to do this you'll have to put it afterward in order to alphabetize it. - Leo Izen (Traneptora)
Will send v2 with fix. I actually prefer it, I wasn't sure if it would be seen the same way.
v2 on the way.
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c index 761ac97ec6..959b267e69 100644 --- a/libavformat/dvdvideodec.c +++ b/libavformat/dvdvideodec.c @@ -30,6 +30,7 @@ * 7) Close the dvdnav VM, and free dvdread's IFO structures */ +#include <inttypes.h> #include <dvdnav/dvdnav.h> #include <dvdread/dvd_reader.h> #include <dvdread/ifo_read.h>
Since log statements printing int64 were made portable in 4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include inttypes.h explicitly (as it is unclear where PRId64 and such are coming from now). Reported-by: Traneptora Signed-off-by: Marth64 <marth64@proxyid.net> --- libavformat/dvdvideodec.c | 1 + 1 file changed, 1 insertion(+)