diff mbox series

[FFmpeg-devel,v2] doc: Add libtoch backend option to dnn_processing

Message ID 20240325021508.371987-1-wenbin.chen@intel.com
State Accepted
Commit ea2e0e92ed008fcea6c34c91ce523479e564131d
Headers show
Series [FFmpeg-devel,v2] doc: Add libtoch backend option to dnn_processing | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Chen, Wenbin March 25, 2024, 2:15 a.m. UTC
From: Wenbin Chen <wenbin.chen@intel.com>

Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
---
 doc/filters.texi | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Guo, Yejun March 25, 2024, 11:16 a.m. UTC | #1
> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> wenbin.chen-at-intel.com@ffmpeg.org
> Sent: Monday, March 25, 2024 10:15 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH v2] doc: Add libtoch backend option to
> dnn_processing
> 
> From: Wenbin Chen <wenbin.chen@intel.com>
> 
> Signed-off-by: Wenbin Chen <wenbin.chen@intel.com>
> ---
>  doc/filters.texi | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 18f0d1c5a7..bfa8ccec8b 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -12073,11 +12073,21 @@ need to build and install the OpenVINO for C
> library (see
>  @code{--enable-libopenvino} (--extra-cflags=-I... --extra-ldflags=-L... might
>  be needed if the header files and libraries are not installed into system path)
> 
> +@item torch
> +Libtorch backend. To enable this backend you need to build and install
> Libtroch
> +for C++ library. Please download cxx11 ABI version (see
> +@url{https://pytorch.org/get-started/locally})
> +and configure FFmpeg with @code{--enable-libtorch
> +--extra-cflags=-I/libtorch_root/libtorch/include
> +--extra-cflags=-I/libtorch_root/libtorch/include/torch/csrc/api/include
> +--extra-ldflags=-L/libtorch_root/libtorch/lib/}
> +
>  @end table
> 
>  @item model
>  Set path to model file specifying network architecture and its parameters.
> -Note that different backends use different file formats. TensorFlow,
> OpenVINO backend can load files for only its format.
> +Note that different backends use different file formats. TensorFlow,
> OpenVINO
> +and Libtorch backend can load files for only its format.
> 
LGTM, will push soon, thanks.
Leo Izen March 26, 2024, 4:03 p.m. UTC | #2
On 3/25/24 07:16, Guo, Yejun wrote:
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>> wenbin.chen-at-intel.com@ffmpeg.org
>> Sent: Monday, March 25, 2024 10:15 AM
>> To: ffmpeg-devel@ffmpeg.org
>> Subject: [FFmpeg-devel] [PATCH v2] doc: Add libtoch backend option to
>> dnn_processing

Typo in commit message, you want libtorch, not libtoch.

- Leo Izen (Traneptora)
Chen, Wenbin March 27, 2024, 7:43 a.m. UTC | #3
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
> >> wenbin.chen-at-intel.com@ffmpeg.org
> >> Sent: Monday, March 25, 2024 10:15 AM
> >> To: ffmpeg-devel@ffmpeg.org
> >> Subject: [FFmpeg-devel] [PATCH v2] doc: Add libtoch backend option to
> >> dnn_processing
> 
> Typo in commit message, you want libtorch, not libtoch.
> 
> - Leo Izen (Traneptora)

Thanks for your comment. I didn't notice that.
It is merged, so I cannot fix it.

> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff mbox series

Patch

diff --git a/doc/filters.texi b/doc/filters.texi
index 18f0d1c5a7..bfa8ccec8b 100644
--- a/doc/filters.texi
+++ b/doc/filters.texi
@@ -12073,11 +12073,21 @@  need to build and install the OpenVINO for C library (see
 @code{--enable-libopenvino} (--extra-cflags=-I... --extra-ldflags=-L... might
 be needed if the header files and libraries are not installed into system path)
 
+@item torch
+Libtorch backend. To enable this backend you need to build and install Libtroch
+for C++ library. Please download cxx11 ABI version (see
+@url{https://pytorch.org/get-started/locally})
+and configure FFmpeg with @code{--enable-libtorch
+--extra-cflags=-I/libtorch_root/libtorch/include
+--extra-cflags=-I/libtorch_root/libtorch/include/torch/csrc/api/include
+--extra-ldflags=-L/libtorch_root/libtorch/lib/}
+
 @end table
 
 @item model
 Set path to model file specifying network architecture and its parameters.
-Note that different backends use different file formats. TensorFlow, OpenVINO backend can load files for only its format.
+Note that different backends use different file formats. TensorFlow, OpenVINO
+and Libtorch backend can load files for only its format.
 
 @item input
 Set the input name of the dnn network.