| Message ID | 20240403225134.31764-1-michael@niedermayer.cc |
|---|---|
| State | Accepted |
| Commit | 28c7094b25b689185155a6833caf2747b94774a4 |
| Headers | show |
| Series | [FFmpeg-devel,1/5] avcodec/wavarc: fix signed integer overflow in block type 6/19 | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Thu, Apr 04, 2024 at 12:51:30AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2088796289 + -91276551 cannot be represented in type 'int' > Fixes: 67772/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6533568953122816 > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavcodec/wavarc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) will apply and backport these [...]
diff --git a/libavcodec/wavarc.c b/libavcodec/wavarc.c index 7083494cd81..b4b26958e6f 100644 --- a/libavcodec/wavarc.c +++ b/libavcodec/wavarc.c @@ -647,7 +647,7 @@ static int decode_5elp(AVCodecContext *avctx, for (int o = 0; o < order; o++) sum += s->filter[ch][o] * (unsigned)samples[n + 70 - o - 1]; - samples[n + 70] += ac_out[n] + (sum >> 4); + samples[n + 70] += ac_out[n] + (unsigned)(sum >> 4); } for (int n = 0; n < 70; n++)
Fixes: signed integer overflow: -2088796289 + -91276551 cannot be represented in type 'int' Fixes: 67772/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WAVARC_fuzzer-6533568953122816 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavcodec/wavarc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)