| Message ID | 20240409135034.95513-3-jdek@itanimul.li |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,v3,1/5] configure: simplify bigendian check | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Tue, 9 Apr 2024, J. Dekker wrote: > Note that the config.sh file is left without a shebang, this file is > supposed to be sourced into the current environment. > > This commit is purely cosmetic. > > Signed-off-by: J. Dekker <jdek@itanimul.li> > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, this set seems fine to me - the explanations seem good now. (I'd consider merging patches 3-5 though, but keeping the full commit message from patch 3).) // Martin
Martin Storsjö <martin@martin.st> writes: > On Tue, 9 Apr 2024, J. Dekker wrote: > >> Note that the config.sh file is left without a shebang, this file is >> supposed to be sourced into the current environment. >> >> This commit is purely cosmetic. >> >> Signed-off-by: J. Dekker <jdek@itanimul.li> >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Thanks, this set seems fine to me - the explanations seem good now. (I'd > consider merging patches 3-5 though, but keeping the full commit message from > patch 3).) > Thanks for review, pushed with 3-5 squashed.
diff --git a/configure b/configure index 7c22772485..55f1fc354d 100755 --- a/configure +++ b/configure @@ -4737,7 +4737,7 @@ chmod +x $TMPE # make sure we can execute files in $TMPDIR cat > $TMPSH 2>> $logfile <<EOF -#! /bin/sh +#!/bin/sh EOF chmod +x $TMPSH >> $logfile 2>&1 if ! $TMPSH >> $logfile 2>&1; then
Note that the config.sh file is left without a shebang, this file is supposed to be sourced into the current environment. This commit is purely cosmetic. Signed-off-by: J. Dekker <jdek@itanimul.li> --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)