| Message ID | 20240422005351.4179419-1-michael@niedermayer.cc |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] avfilter/avfiltergraph: Add comment about ignored return value | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
Michael Niedermayer: > Fixes: CID1397741 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavfilter/avfiltergraph.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c > index 0c569eb218e..4eeaa33d5e9 100644 > --- a/libavfilter/avfiltergraph.c > +++ b/libavfilter/avfiltergraph.c > @@ -1410,7 +1410,7 @@ int avfilter_graph_request_oldest(AVFilterGraph *graph) > if (r == AVERROR(EAGAIN) && > !oldest->frame_wanted_out && !oldesti->frame_blocked_in && > !oldesti->status_in) > - ff_request_frame(oldest); > + ff_request_frame(oldest); // return value is intentionally ignored > else if (r < 0) > return r; > } Isn't the typical way to signal this to cast the return value to void? - Andreas
On Tue, Apr 30, 2024 at 09:14:16AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1397741 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > --- > > libavfilter/avfiltergraph.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c > > index 0c569eb218e..4eeaa33d5e9 100644 > > --- a/libavfilter/avfiltergraph.c > > +++ b/libavfilter/avfiltergraph.c > > @@ -1410,7 +1410,7 @@ int avfilter_graph_request_oldest(AVFilterGraph *graph) > > if (r == AVERROR(EAGAIN) && > > !oldest->frame_wanted_out && !oldesti->frame_blocked_in && > > !oldesti->status_in) > > - ff_request_frame(oldest); > > + ff_request_frame(oldest); // return value is intentionally ignored > > else if (r < 0) > > return r; > > } > > Isn't the typical way to signal this to cast the return value to void? yes, i will push that change instead thx [...]
diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 0c569eb218e..4eeaa33d5e9 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfiltergraph.c @@ -1410,7 +1410,7 @@ int avfilter_graph_request_oldest(AVFilterGraph *graph) if (r == AVERROR(EAGAIN) && !oldest->frame_wanted_out && !oldesti->frame_blocked_in && !oldesti->status_in) - ff_request_frame(oldest); + ff_request_frame(oldest); // return value is intentionally ignored else if (r < 0) return r; }
Fixes: CID1397741 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavfilter/avfiltergraph.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)