| Message ID | 20240422011159.4180004-1-michael@niedermayer.cc |
|---|---|
| State | Accepted |
| Commit | 02301017d28422e4d0a4badb16f2226e70ec534a |
| Headers | show |
| Series | [FFmpeg-devel] avfilter/vf_thumbnail_cuda: Set ret before checking it | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On 22.04.2024 03:11, Michael Niedermayer wrote: > Fixes: CID1418336 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavfilter/vf_thumbnail_cuda.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c > index 0459070800a..8efb54f0792 100644 > --- a/libavfilter/vf_thumbnail_cuda.c > +++ b/libavfilter/vf_thumbnail_cuda.c > @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > hist[i] = 4 * hist[i]; > } > > - CHECK_CU(cu->cuCtxPopCurrent(&dummy)); > + ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy)); > if (ret < 0) > return ret; > LGTM
On Mon, Apr 22, 2024 at 12:17:02PM +0200, Timo Rothenpieler wrote: > > > On 22.04.2024 03:11, Michael Niedermayer wrote: > > Fixes: CID1418336 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > --- > > libavfilter/vf_thumbnail_cuda.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c > > index 0459070800a..8efb54f0792 100644 > > --- a/libavfilter/vf_thumbnail_cuda.c > > +++ b/libavfilter/vf_thumbnail_cuda.c > > @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > > hist[i] = 4 * hist[i]; > > } > > - CHECK_CU(cu->cuCtxPopCurrent(&dummy)); > > + ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy)); > > if (ret < 0) > > return ret; > > LGTM will apply thx [...]
diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c index 0459070800a..8efb54f0792 100644 --- a/libavfilter/vf_thumbnail_cuda.c +++ b/libavfilter/vf_thumbnail_cuda.c @@ -291,7 +291,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) hist[i] = 4 * hist[i]; } - CHECK_CU(cu->cuCtxPopCurrent(&dummy)); + ret = CHECK_CU(cu->cuCtxPopCurrent(&dummy)); if (ret < 0) return ret;
Fixes: CID1418336 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavfilter/vf_thumbnail_cuda.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)