diff mbox series

[FFmpeg-devel,1/3] avcodec/ilbcdec: Remove dead code

Message ID 20240510140705.443047-1-michael@niedermayer.cc
State Accepted
Commit 8a64a003b5d567354e82af679e056615c8464a6f
Headers show
Series [FFmpeg-devel,1/3] avcodec/ilbcdec: Remove dead code | expand

Commit Message

Michael Niedermayer May 10, 2024, 2:07 p.m. UTC
Yes the same dead code is in "iLBC Speech Coder ANSI-C Source Code"

Fixes: CID1509370 Logically dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/ilbcdec.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Michael Niedermayer June 7, 2024, 6:53 p.m. UTC | #1
On Fri, May 10, 2024 at 04:07:03PM +0200, Michael Niedermayer wrote:
> Yes the same dead code is in "iLBC Speech Coder ANSI-C Source Code"
> 
> Fixes: CID1509370 Logically dead code
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavcodec/ilbcdec.c | 6 ------
>  1 file changed, 6 deletions(-)

will apply the remaining 2 patches of this set

[...]
diff mbox series

Patch

diff --git a/libavcodec/ilbcdec.c b/libavcodec/ilbcdec.c
index 4ecdff41831..ba1da168bc0 100644
--- a/libavcodec/ilbcdec.c
+++ b/libavcodec/ilbcdec.c
@@ -1095,12 +1095,6 @@  static void do_plc(int16_t *plc_residual,      /* (o) concealed residual */
 
         if (s->consPLICount * s->block_samples > 320) {
             use_gain = 29491;   /* 0.9 in Q15 */
-        } else if (s->consPLICount * s->block_samples > 640) {
-            use_gain = 22938;   /* 0.7 in Q15 */
-        } else if (s->consPLICount * s->block_samples > 960) {
-            use_gain = 16384;   /* 0.5 in Q15 */
-        } else if (s->consPLICount * s->block_samples > 1280) {
-            use_gain = 0;       /* 0.0 in Q15 */
         }
 
         /* Compute mixing factor of picth repeatition and noise: