diff mbox series

[FFmpeg-devel] fate: add tests for xHE-AAC

Message ID 20240521020544.1295949-1-dev@lynne.ee
State New
Headers show
Series [FFmpeg-devel] fate: add tests for xHE-AAC | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed

Commit Message

Lynne May 21, 2024, 2:05 a.m. UTC 
Starting off small with a few features.
Samples and reference decoded files copied from the official ISO
reference suite.
---
Samples and references: https://files.lynne.ee/xhe_refs/

 tests/fate/aac.mak | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Paul B Mahol May 21, 2024, 7:18 a.m. UTC | #1 
On Tue, May 21, 2024 at 4:05 AM Lynne via ffmpeg-devel <
ffmpeg-devel@ffmpeg.org> wrote:

> Starting off small with a few features.
> Samples and reference decoded files copied from the official ISO
> reference suite.
>

Sorry for my ignorance, but is such copy allowed from them?

---
> Samples and references: https://files.lynne.ee/xhe_refs/
>
>  tests/fate/aac.mak | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
> index 817944773d..ff58392ad9 100644
> --- a/tests/fate/aac.mak
> +++ b/tests/fate/aac.mak
> @@ -62,6 +62,14 @@ FATE_AAC += fate-aac-ap05_48
>  fate-aac-ap05_48: CMD = pcm -i $(TARGET_SAMPLES)/aac/ap05_48.mp4
>  fate-aac-ap05_48: REF = $(SAMPLES)/aac/ap05_48.s16
>
> +FATE_AAC += fate-aac-fd_2_c1_ms_0x01
> +fate-aac-fd_2_c1_ms_0x01: CMD = pcm -i
> $(TARGET_SAMPLES)/aac/Fd_2_c1_Ms_0x01.mp4
> +fate-aac-fd_2_c1_ms_0x01: REF = $(SAMPLES)/aac/Fd_2_c1_Ms_0x01.s16
> +
> +FATE_AAC += fate-aac-fd_2_c1_ms_0x04
> +fate-aac-fd_2_c1_ms_0x04: CMD = pcm -i
> $(TARGET_SAMPLES)/aac/Fd_2_c1_Ms_0x04.mp4
> +fate-aac-fd_2_c1_ms_0x04: REF = $(SAMPLES)/aac/Fd_2_c1_Ms_0x04.s16
> +
>  FATE_AAC += fate-aac-er_ad6000np_44_ep0
>  fate-aac-er_ad6000np_44_ep0: CMD = pcm -i
> $(TARGET_SAMPLES)/aac/er_ad6000np_44_ep0.mp4
>  fate-aac-er_ad6000np_44_ep0: REF = $(SAMPLES)/aac/er_ad6000np_44.s16
> --
> 2.43.0.381.gb435a96ce8
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Lynne May 21, 2024, 8:18 a.m. UTC | #2 
On 21/05/2024 09:18, Paul B Mahol wrote:
> 
> 
> On Tue, May 21, 2024 at 4:05 AM Lynne via ffmpeg-devel 
> <ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>> wrote:
> 
>     Starting off small with a few features.
>     Samples and reference decoded files copied from the official ISO
>     reference suite.
> 
> 
> Sorry for my ignorance, but is such copy allowed from them?
> 
>     ---
>     Samples and references: https://files.lynne.ee/xhe_refs/
>     <https://files.lynne.ee/xhe_refs/>
> 
>       tests/fate/aac.mak | 8 ++++++++
>       1 file changed, 8 insertions(+)
> 
>     diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
>     index 817944773d..ff58392ad9 100644
>     --- a/tests/fate/aac.mak
>     +++ b/tests/fate/aac.mak
>     @@ -62,6 +62,14 @@ FATE_AAC += fate-aac-ap05_48
>       fate-aac-ap05_48: CMD = pcm -i $(TARGET_SAMPLES)/aac/ap05_48.mp4
>       fate-aac-ap05_48: REF = $(SAMPLES)/aac/ap05_48.s16
> 
>     +FATE_AAC += fate-aac-fd_2_c1_ms_0x01
>     +fate-aac-fd_2_c1_ms_0x01: CMD = pcm -i
>     $(TARGET_SAMPLES)/aac/Fd_2_c1_Ms_0x01.mp4
>     +fate-aac-fd_2_c1_ms_0x01: REF = $(SAMPLES)/aac/Fd_2_c1_Ms_0x01.s16
>     +
>     +FATE_AAC += fate-aac-fd_2_c1_ms_0x04
>     +fate-aac-fd_2_c1_ms_0x04: CMD = pcm -i
>     $(TARGET_SAMPLES)/aac/Fd_2_c1_Ms_0x04.mp4
>     +fate-aac-fd_2_c1_ms_0x04: REF = $(SAMPLES)/aac/Fd_2_c1_Ms_0x04.s16
>     +
>       FATE_AAC += fate-aac-er_ad6000np_44_ep0
>       fate-aac-er_ad6000np_44_ep0: CMD = pcm -i
>     $(TARGET_SAMPLES)/aac/er_ad6000np_44_ep0.mp4
>       fate-aac-er_ad6000np_44_ep0: REF = $(SAMPLES)/aac/er_ad6000np_44.s16
>     -- 
>     2.43.0.381.gb435a96ce8
>     _______________________________________________
>     ffmpeg-devel mailing list
>     ffmpeg-devel@ffmpeg.org <mailto:ffmpeg-devel@ffmpeg.org>
>     https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>     <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>
> 
>     To unsubscribe, visit link above, or email
>     ffmpeg-devel-request@ffmpeg.org
>     <mailto:ffmpeg-devel-request@ffmpeg.org> with subject "unsubscribe".
> 

We have code from very big movie productions that people still buy BDs 
of and go to the cinema, and you're worried about the ISO noticing that 
we're hosting a small set of samples (which anyone can download) to test 
machines?
https://standards.iso.org/iso-iec/23003/-3/ed-2/en/
diff mbox series

Patch

diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
index 817944773d..ff58392ad9 100644
--- a/tests/fate/aac.mak
+++ b/tests/fate/aac.mak
@@ -62,6 +62,14 @@  FATE_AAC += fate-aac-ap05_48
 fate-aac-ap05_48: CMD = pcm -i $(TARGET_SAMPLES)/aac/ap05_48.mp4
 fate-aac-ap05_48: REF = $(SAMPLES)/aac/ap05_48.s16
 
+FATE_AAC += fate-aac-fd_2_c1_ms_0x01
+fate-aac-fd_2_c1_ms_0x01: CMD = pcm -i $(TARGET_SAMPLES)/aac/Fd_2_c1_Ms_0x01.mp4
+fate-aac-fd_2_c1_ms_0x01: REF = $(SAMPLES)/aac/Fd_2_c1_Ms_0x01.s16
+
+FATE_AAC += fate-aac-fd_2_c1_ms_0x04
+fate-aac-fd_2_c1_ms_0x04: CMD = pcm -i $(TARGET_SAMPLES)/aac/Fd_2_c1_Ms_0x04.mp4
+fate-aac-fd_2_c1_ms_0x04: REF = $(SAMPLES)/aac/Fd_2_c1_Ms_0x04.s16
+
 FATE_AAC += fate-aac-er_ad6000np_44_ep0
 fate-aac-er_ad6000np_44_ep0: CMD = pcm -i $(TARGET_SAMPLES)/aac/er_ad6000np_44_ep0.mp4
 fate-aac-er_ad6000np_44_ep0: REF = $(SAMPLES)/aac/er_ad6000np_44.s16