diff mbox series

[FFmpeg-devel,1/7] avutil/random_seed: Avoid dead returns

Message ID 20240521024652.1006233-1-michael@niedermayer.cc
State Accepted
Commit 87846f64b5705f2759c157b80073fc841ecc0876
Headers show
Series [FFmpeg-devel,1/7] avutil/random_seed: Avoid dead returns | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Michael Niedermayer May 21, 2024, 2:46 a.m. UTC
Fixes: CID1538296 Structurally dead code

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavutil/random_seed.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Michael Niedermayer May 27, 2024, 11:47 p.m. UTC | #1
On Tue, May 21, 2024 at 04:46:46AM +0200, Michael Niedermayer wrote:
> Fixes: CID1538296 Structurally dead code
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavutil/random_seed.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

will apply patches 1-6

[...]
diff mbox series

Patch

diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c
index 6d399cee49c..8a4e4f1fc0b 100644
--- a/libavutil/random_seed.c
+++ b/libavutil/random_seed.c
@@ -158,10 +158,10 @@  int av_random_bytes(uint8_t* buf, size_t len)
 #elif CONFIG_OPENSSL
     if (RAND_bytes(buf, len) == 1)
         return 0;
-    err = AVERROR_EXTERNAL;
-#endif
-
+    return AVERROR_EXTERNAL;
+#else
     return err;
+#endif
 }
 
 uint32_t av_get_random_seed(void)