| Message ID | 20240521150413.1364298-1-dev@lynne.ee |
|---|---|
| State | Accepted |
| Commit | d43e1238374e77788977b2427612b526d6840a1e |
| Headers | show |
| Series | [FFmpeg-devel] checkasm: print bench runs when benchmarking | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> writes: > Helps make sense of the possible noise in the results. > --- > tests/checkasm/checkasm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c > index 669f2be9c1..b1c175b95d 100644 > --- a/tests/checkasm/checkasm.c > +++ b/tests/checkasm/checkasm.c > @@ -892,6 +892,9 @@ int main(int argc, char *argv[]) > fprintf(stderr, "checkasm: using random seed %u\n", seed); > av_lfg_init(&checkasm_lfg, seed); > > + if (state.bench_pattern) > + fprintf(stderr, "checkasm: bench runs %" PRIu64 " (1 << %i)\n", bench_runs, av_log2(bench_runs)); > + > check_cpu_flag(NULL, 0); > for (i = 0; cpus[i].flag; i++) > check_cpu_flag(cpus[i].name, cpus[i].flag); LGTM.
On 21/05/2024 17:07, J. Dekker wrote: > > Lynne via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> writes: > >> Helps make sense of the possible noise in the results. >> --- >> tests/checkasm/checkasm.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c >> index 669f2be9c1..b1c175b95d 100644 >> --- a/tests/checkasm/checkasm.c >> +++ b/tests/checkasm/checkasm.c >> @@ -892,6 +892,9 @@ int main(int argc, char *argv[]) >> fprintf(stderr, "checkasm: using random seed %u\n", seed); >> av_lfg_init(&checkasm_lfg, seed); >> >> + if (state.bench_pattern) >> + fprintf(stderr, "checkasm: bench runs %" PRIu64 " (1 << %i)\n", bench_runs, av_log2(bench_runs)); >> + >> check_cpu_flag(NULL, 0); >> for (i = 0; cpus[i].flag; i++) >> check_cpu_flag(cpus[i].name, cpus[i].flag); > > LGTM. > Thanks, pushed
diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c index 669f2be9c1..b1c175b95d 100644 --- a/tests/checkasm/checkasm.c +++ b/tests/checkasm/checkasm.c @@ -892,6 +892,9 @@ int main(int argc, char *argv[]) fprintf(stderr, "checkasm: using random seed %u\n", seed); av_lfg_init(&checkasm_lfg, seed); + if (state.bench_pattern) + fprintf(stderr, "checkasm: bench runs %" PRIu64 " (1 << %i)\n", bench_runs, av_log2(bench_runs)); + check_cpu_flag(NULL, 0); for (i = 0; cpus[i].flag; i++) check_cpu_flag(cpus[i].name, cpus[i].flag);