diff mbox series

[FFmpeg-devel,3/3] avformat/hlsenc: Remove dead ret stores

Message ID 20240525111814.2587729-3-michael@niedermayer.cc
State Accepted
Commit 3c1915d7762db3dc1d3b1185ec2bb27b7682c00e
Headers show
Series [FFmpeg-devel,1/3] avformat/file: check for lseek() failure | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Michael Niedermayer May 25, 2024, 11:18 a.m. UTC
Fixes: CID1529222 Unused value

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavformat/hlsenc.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Steven Liu May 25, 2024, 12:41 p.m. UTC | #1
Michael Niedermayer <michael@niedermayer.cc> 于2024年5月25日周六 19:18写道:

>
> Fixes: CID1529222 Unused value
>
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavformat/hlsenc.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
> index 0e2843c6bc5..8a43ef6232a 100644
> --- a/libavformat/hlsenc.c
> +++ b/libavformat/hlsenc.c
> @@ -1582,8 +1582,6 @@ static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
>      ret = hlsenc_io_open(s, byterange_mode ? &hls->m3u8_out : &vs->out, temp_filename, &options);
>      av_dict_free(&options);
>      if (ret < 0) {
> -        if (hls->ignore_io_errors)
> -            ret = 0;
>          goto fail;
>      }
>
> @@ -1641,8 +1639,6 @@ static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
>          ret = hlsenc_io_open(s, &hls->sub_m3u8_out, temp_vtt_filename, &options);
>          av_dict_free(&options);
>          if (ret < 0) {
> -            if (hls->ignore_io_errors)
> -                ret = 0;
>              goto fail;
>          }
>          ff_hls_write_playlist_header(hls->sub_m3u8_out, hls->version, hls->allowcache,
> --
> 2.45.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

LGTM

Thanks
Steven
diff mbox series

Patch

diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 0e2843c6bc5..8a43ef6232a 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -1582,8 +1582,6 @@  static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
     ret = hlsenc_io_open(s, byterange_mode ? &hls->m3u8_out : &vs->out, temp_filename, &options);
     av_dict_free(&options);
     if (ret < 0) {
-        if (hls->ignore_io_errors)
-            ret = 0;
         goto fail;
     }
 
@@ -1641,8 +1639,6 @@  static int hls_window(AVFormatContext *s, int last, VariantStream *vs)
         ret = hlsenc_io_open(s, &hls->sub_m3u8_out, temp_vtt_filename, &options);
         av_dict_free(&options);
         if (ret < 0) {
-            if (hls->ignore_io_errors)
-                ret = 0;
             goto fail;
         }
         ff_hls_write_playlist_header(hls->sub_m3u8_out, hls->version, hls->allowcache,