diff mbox series

[FFmpeg-devel,14/17] avdevice/dshow: Cleanup also on av_log case

Message ID 20240526235230.2876318-14-michael@niedermayer.cc
State New
Headers show
Series [FFmpeg-devel,01/17] avcodec/dxva2: Initialize dxva_size and check it | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Michael Niedermayer May 26, 2024, 11:52 p.m. UTC 
Fixes: CID1598550 Resource leak

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavdevice/dshow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer July 2, 2024, 7:20 p.m. UTC | #1 
On Mon, May 27, 2024 at 01:52:26AM +0200, Michael Niedermayer wrote:
> Fixes: CID1598550 Resource leak
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavdevice/dshow.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

can someone with a clue about and means to test dshow review the dshow
patches of this set ?
i dont feel comfortable to just apply some of these with no testing
and no review

thx

[...]
Roger Pack July 22, 2024, 5:57 p.m. UTC | #2 
On Tue, Jul 2, 2024 at 1:39 PM Michael Niedermayer
<michael@niedermayer.cc> wrote:
>
> On Mon, May 27, 2024 at 01:52:26AM +0200, Michael Niedermayer wrote:
> > Fixes: CID1598550 Resource leak
> >
> > Sponsored-by: Sovereign Tech Fund
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  libavdevice/dshow.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> can someone with a clue about and means to test dshow review the dshow
> patches of this set ?
> i dont feel comfortable to just apply some of these with no testing
> and no review

They seem to not have broken anything, thanks for looking into it! :)
diff mbox series

Patch

diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
index 557cf33161e..645c33ea2e6 100644
--- a/libavdevice/dshow.c
+++ b/libavdevice/dshow.c
@@ -1001,7 +1001,7 @@  dshow_cycle_formats(AVFormatContext *avctx, enum dshowDeviceType devtype,
                     "  ch=%2u, bits=%2u, rate=%6lu\n",
                     fx->nChannels, fx->wBitsPerSample, fx->nSamplesPerSec
                 );
-                continue;
+                goto next;
             }
             if (
                 (requested_sample_rate && requested_sample_rate != fx->nSamplesPerSec) ||