diff mbox series

[FFmpeg-devel] avcodec/aacdec_lpd: remove unused local variables

Message ID 20240609001754.260928-1-leo.izen@gmail.com
State New
Headers show
Series [FFmpeg-devel] avcodec/aacdec_lpd: remove unused local variables | expand

Checks

Context Check Description
andriy/make_x86 fail Make failed

Commit Message

Leo Izen June 9, 2024, 12:17 a.m. UTC
int idx, and int first_tcx_flag are set but not used, so this commit
removes their declarations and assignments.

Signed-off-by: Leo Izen <leo.izen@gmail.com>
---
 libavcodec/aac/aacdec_lpd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Michael Niedermayer June 9, 2024, 10:43 p.m. UTC | #1
On Sat, Jun 08, 2024 at 08:17:54PM -0400, Leo Izen wrote:
> int idx, and int first_tcx_flag are set but not used, so this commit
> removes their declarations and assignments.
> 
> Signed-off-by: Leo Izen <leo.izen@gmail.com>
> ---
>  libavcodec/aac/aacdec_lpd.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c
> index 796edd2ab5..5e9909e361 100644
> --- a/libavcodec/aac/aacdec_lpd.c
> +++ b/libavcodec/aac/aacdec_lpd.c
> @@ -99,7 +99,7 @@ static void parse_qn(GetBitContext *gb, int *qn, int nk_mode, int no_qn)
>  static int parse_codebook_idx(GetBitContext *gb, uint32_t *kv,
>                                int nk_mode, int no_qn)
>  {
> -    int idx, n, nk;
> +    int n, nk;
>  
>      int qn[2];
>      parse_qn(gb, qn, nk_mode, no_qn);

libavcodec/aac/aacdec_lpd.c: In function ‘parse_codebook_idx’:
libavcodec/aac/aacdec_lpd.c:117:5: error: ‘idx’ undeclared (first use in this function)
  117 |     idx = get_bits(gb, 4*n);
      |     ^~~

[...]
diff mbox series

Patch

diff --git a/libavcodec/aac/aacdec_lpd.c b/libavcodec/aac/aacdec_lpd.c
index 796edd2ab5..5e9909e361 100644
--- a/libavcodec/aac/aacdec_lpd.c
+++ b/libavcodec/aac/aacdec_lpd.c
@@ -99,7 +99,7 @@  static void parse_qn(GetBitContext *gb, int *qn, int nk_mode, int no_qn)
 static int parse_codebook_idx(GetBitContext *gb, uint32_t *kv,
                               int nk_mode, int no_qn)
 {
-    int idx, n, nk;
+    int n, nk;
 
     int qn[2];
     parse_qn(gb, qn, nk_mode, no_qn);
@@ -145,7 +145,6 @@  int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac,
     int k;
     const uint8_t *mod;
     int first_ldp_flag;
-    int first_tcx_flag;
 
     ce->ldp.acelp_core_mode = get_bits(gb, 3);
     ce->ldp.lpd_mode = get_bits(gb, 5);
@@ -157,7 +156,6 @@  int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac,
     mod = ff_aac_lpd_mode_tab[ce->ldp.lpd_mode];
 
     first_ldp_flag = !ce->ldp.core_mode_last;
-    first_tcx_flag = 1;
     if (first_ldp_flag)
         ce->ldp.last_lpd_mode = -1; /* last_ldp_mode is a **STATEFUL** value */
 
@@ -179,7 +177,6 @@  int ff_aac_ldp_parse_channel_stream(AACDecContext *ac, AACUSACConfig *usac,
 //            parse_tcx_coding();
             ce->ldp.last_lpd_mode = mod[k];
             k += (1 << (mod[k] - 1));
-            first_tcx_flag = 0;
         }
     }