diff mbox series

[FFmpeg-devel,1/6] avutil/hwcontext_d3d11va: correct sizeof AVD3D11FrameDescriptor

Message ID 20240609154746.4173264-1-michael@niedermayer.cc
State New
Headers show
Series [FFmpeg-devel,1/6] avutil/hwcontext_d3d11va: correct sizeof AVD3D11FrameDescriptor | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Michael Niedermayer June 9, 2024, 3:47 p.m. UTC
Fixes: CID1591909 Wrong sizeof argument

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavutil/hwcontext_d3d11va.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Michael Niedermayer July 7, 2024, 8:23 p.m. UTC | #1
Hi Steve

you are listed as maintainer for d3d11va, there are some trivial patches in
this patchset that i cannot easily test

can you either apply/approve/reject/test/review them

thx

On Sun, Jun 09, 2024 at 05:47:41PM +0200, Michael Niedermayer wrote:
> Fixes: CID1591909 Wrong sizeof argument
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  libavutil/hwcontext_d3d11va.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c
> index 8963c9fc85b..c04ab01a282 100644
> --- a/libavutil/hwcontext_d3d11va.c
> +++ b/libavutil/hwcontext_d3d11va.c
> @@ -202,7 +202,7 @@ static AVBufferRef *wrap_texture_buf(AVHWFramesContext *ctx, ID3D11Texture2D *te
>      desc->texture = tex;
>      desc->index   = index;
>  
> -    buf = av_buffer_create((uint8_t *)desc, sizeof(desc), free_texture, tex, 0);
> +    buf = av_buffer_create((uint8_t *)desc, sizeof(*desc), free_texture, tex, 0);
>      if (!buf) {
>          ID3D11Texture2D_Release(tex);
>          av_free(desc);
> -- 
> 2.45.2
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Steve Lhomme July 8, 2024, 7:51 a.m. UTC | #2
Hi Michael,

All the patches in that patches look good to me. You can apply.

Steve

On 07/07/2024 22:23, Michael Niedermayer wrote:
> Hi Steve
> 
> you are listed as maintainer for d3d11va, there are some trivial patches in
> this patchset that i cannot easily test
> 
> can you either apply/approve/reject/test/review them
> 
> thx
> 
> On Sun, Jun 09, 2024 at 05:47:41PM +0200, Michael Niedermayer wrote:
>> Fixes: CID1591909 Wrong sizeof argument
>>
>> Sponsored-by: Sovereign Tech Fund
>> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
>> ---
>>   libavutil/hwcontext_d3d11va.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c
>> index 8963c9fc85b..c04ab01a282 100644
>> --- a/libavutil/hwcontext_d3d11va.c
>> +++ b/libavutil/hwcontext_d3d11va.c
>> @@ -202,7 +202,7 @@ static AVBufferRef *wrap_texture_buf(AVHWFramesContext *ctx, ID3D11Texture2D *te
>>       desc->texture = tex;
>>       desc->index   = index;
>>   
>> -    buf = av_buffer_create((uint8_t *)desc, sizeof(desc), free_texture, tex, 0);
>> +    buf = av_buffer_create((uint8_t *)desc, sizeof(*desc), free_texture, tex, 0);
>>       if (!buf) {
>>           ID3D11Texture2D_Release(tex);
>>           av_free(desc);
>> -- 
>> 2.45.2
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel@ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email
>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>>
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> If the United States is serious about tackling the national security threats
> related to an insecure 5G network, it needs to rethink the extent to which it
> values corporate profits and government espionage over security.-Bruce Schneier
Michael Niedermayer July 9, 2024, 1:41 p.m. UTC | #3
On Mon, Jul 08, 2024 at 09:51:30AM +0200, Steve Lhomme wrote:
> Hi Michael,
> 
> All the patches in that patches look good to me. You can apply.

will apply

thx


[...]
diff mbox series

Patch

diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c
index 8963c9fc85b..c04ab01a282 100644
--- a/libavutil/hwcontext_d3d11va.c
+++ b/libavutil/hwcontext_d3d11va.c
@@ -202,7 +202,7 @@  static AVBufferRef *wrap_texture_buf(AVHWFramesContext *ctx, ID3D11Texture2D *te
     desc->texture = tex;
     desc->index   = index;
 
-    buf = av_buffer_create((uint8_t *)desc, sizeof(desc), free_texture, tex, 0);
+    buf = av_buffer_create((uint8_t *)desc, sizeof(*desc), free_texture, tex, 0);
     if (!buf) {
         ID3D11Texture2D_Release(tex);
         av_free(desc);