diff mbox series

[FFmpeg-devel,v2] avdevice/avfoundation: add external video devices

Message ID 20240609195108.14606-1-fabi.theo@gmail.com
State New
Headers show
Series [FFmpeg-devel,v2] avdevice/avfoundation: add external video devices | expand

Checks

Context Check Description
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Theo Fabi June 9, 2024, 7:51 p.m. UTC
Video devices categorized by AVFoundation as
'AVCaptureDeviceTypeExternal(Unknown)' (like USB video streams) were not
recognized by libavdevice.

Signed-off-by: Theo Fabi <fabi.theo@gmail.com>
---
 libavdevice/avfoundation.m | 3 +++
 1 file changed, 3 insertions(+)

Comments

Thilo Borgmann June 18, 2024, 3:40 p.m. UTC | #1
Am 09.06.24 um 21:51 schrieb Theo Fabi:
> Video devices categorized by AVFoundation as
> 'AVCaptureDeviceTypeExternal(Unknown)' (like USB video streams) were not
> recognized by libavdevice.
> 
> Signed-off-by: Theo Fabi <fabi.theo@gmail.com>
> ---
>   libavdevice/avfoundation.m | 3 +++
>   1 file changed, 3 insertions(+)

Ok. Will push soon.

Thanks,
Thilo
diff mbox series

Patch

diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m
index e558ad7d90..c5a09c6563 100644
--- a/libavdevice/avfoundation.m
+++ b/libavdevice/avfoundation.m
@@ -788,6 +788,9 @@  static NSArray* getDevicesWithMediaType(AVMediaType mediaType) {
         #endif
         #if (TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED >= 170000 || (TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED >= 140000))
             [deviceTypes addObject: AVCaptureDeviceTypeContinuityCamera];
+            [deviceTypes addObject: AVCaptureDeviceTypeExternal];
+        #elif (TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED < 140000)
+            [deviceTypes addObject: AVCaptureDeviceTypeExternalUnknown];
         #endif
     } else if (mediaType == AVMediaTypeAudio) {
         #if (TARGET_OS_IPHONE && __IPHONE_OS_VERSION_MIN_REQUIRED >= 170000 || (TARGET_OS_OSX && __MAC_OS_X_VERSION_MIN_REQUIRED >= 140000))