| Message ID | 20240610202322.786800-3-remi@remlab.net |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,PATCHv4,1/4] lavc/h263dsp: add DCT dequantisation functions | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On 6/10/2024 5:23 PM, Rémi Denis-Courmont wrote: > --- > tests/checkasm/h263dsp.c | 53 +++++++++++++++++++++++++++++++++++++++- > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c > index 2d0957a90b..a8530403ee 100644 > --- a/tests/checkasm/h263dsp.c > +++ b/tests/checkasm/h263dsp.c > @@ -18,13 +18,61 @@ > * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > */ > > +#include <stdbool.h> > #include <string.h> > > #include "checkasm.h" > > -#include "libavcodec/h263dsp.h" > +#include "libavutil/avassert.h" > #include "libavutil/mem.h" > #include "libavutil/mem_internal.h" > +#include "libavcodec/h263dsp.h" > +#include "libavcodec/mpegvideodata.h" > + > +static uint_fast8_t mpeg_qscale_rnd(void) > +{ > + int n = rnd(), q = (n >> 1) & 31; > + > + if (n & 1) > + return ff_mpeg2_non_linear_qscale[q]; > + else > + return q << 1; > +} > + > +typedef void (*unquantizer)(int16_t *, size_t, int, int); > + > +static void check_dct_unquantize(unquantizer func, const char *name) > +{ > +#define LEN 64 > + LOCAL_ALIGNED_16(int16_t, block0, [LEN]); > + LOCAL_ALIGNED_16(int16_t, block1, [LEN]); > + size_t coeffs = rnd() % LEN; > + const int qscale = mpeg_qscale_rnd(); > + const int qmul = qscale << 1; > + const int qadd = (rnd() & 1) ? (qscale - 1) | 1 : 0; > + > + declare_func(void, int16_t *, size_t, int, int); > + > + for (size_t i = 0; i < LEN; i++) > + block1[i] = block0[i] = (rnd() & 1) ? rnd() : 0; Don't waste rng bits. for (size_t i = 0; i < LEN; i++) { int n = rnd(); block1[i] = block0[i] = (n & 1) ? n : 0; } > + > + if (check_func(func, "h263dsp.dct_unquantize_%s", name)) { > + call_ref(block0, 0, qmul, qadd); > + call_new(block1, 0, qmul, qadd); > + > + if (block0[0] != block1[0]) > + fail(); > + > + av_assert0(coeffs < LEN); > + call_ref(block0, coeffs, qmul, qadd); > + call_new(block1, coeffs, qmul, qadd); > + > + if (memcmp(block0, block1, (coeffs + 1) * sizeof (int16_t))) > + fail(); > + > + bench_new(block1, LEN - 1, qmul, qadd); > + } > +} > > typedef void (*filter)(uint8_t *src, int stride, int qscale); > > @@ -56,6 +104,9 @@ void checkasm_check_h263dsp(void) > H263DSPContext ctx; > > ff_h263dsp_init(&ctx); > + check_dct_unquantize(ctx.h263_dct_unquantize_intra, "intra"); > + check_dct_unquantize(ctx.h263_dct_unquantize_inter, "inter"); > + report("dct_unquantize"); > check_loop_filter('h', ctx.h263_h_loop_filter); > check_loop_filter('v', ctx.h263_v_loop_filter); > report("loop_filter");
diff --git a/tests/checkasm/h263dsp.c b/tests/checkasm/h263dsp.c index 2d0957a90b..a8530403ee 100644 --- a/tests/checkasm/h263dsp.c +++ b/tests/checkasm/h263dsp.c @@ -18,13 +18,61 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ +#include <stdbool.h> #include <string.h> #include "checkasm.h" -#include "libavcodec/h263dsp.h" +#include "libavutil/avassert.h" #include "libavutil/mem.h" #include "libavutil/mem_internal.h" +#include "libavcodec/h263dsp.h" +#include "libavcodec/mpegvideodata.h" + +static uint_fast8_t mpeg_qscale_rnd(void) +{ + int n = rnd(), q = (n >> 1) & 31; + + if (n & 1) + return ff_mpeg2_non_linear_qscale[q]; + else + return q << 1; +} + +typedef void (*unquantizer)(int16_t *, size_t, int, int); + +static void check_dct_unquantize(unquantizer func, const char *name) +{ +#define LEN 64 + LOCAL_ALIGNED_16(int16_t, block0, [LEN]); + LOCAL_ALIGNED_16(int16_t, block1, [LEN]); + size_t coeffs = rnd() % LEN; + const int qscale = mpeg_qscale_rnd(); + const int qmul = qscale << 1; + const int qadd = (rnd() & 1) ? (qscale - 1) | 1 : 0; + + declare_func(void, int16_t *, size_t, int, int); + + for (size_t i = 0; i < LEN; i++) + block1[i] = block0[i] = (rnd() & 1) ? rnd() : 0; + + if (check_func(func, "h263dsp.dct_unquantize_%s", name)) { + call_ref(block0, 0, qmul, qadd); + call_new(block1, 0, qmul, qadd); + + if (block0[0] != block1[0]) + fail(); + + av_assert0(coeffs < LEN); + call_ref(block0, coeffs, qmul, qadd); + call_new(block1, coeffs, qmul, qadd); + + if (memcmp(block0, block1, (coeffs + 1) * sizeof (int16_t))) + fail(); + + bench_new(block1, LEN - 1, qmul, qadd); + } +} typedef void (*filter)(uint8_t *src, int stride, int qscale); @@ -56,6 +104,9 @@ void checkasm_check_h263dsp(void) H263DSPContext ctx; ff_h263dsp_init(&ctx); + check_dct_unquantize(ctx.h263_dct_unquantize_intra, "intra"); + check_dct_unquantize(ctx.h263_dct_unquantize_inter, "inter"); + report("dct_unquantize"); check_loop_filter('h', ctx.h263_h_loop_filter); check_loop_filter('v', ctx.h263_v_loop_filter); report("loop_filter");