Message ID | 20240611215906.1106071-3-michael@niedermayer.cc |
---|---|
State | New |
Headers | show |
Series | [FFmpeg-devel,1/4] avfilter/avf_showcwt: Check av_parse_video_rate() for failure | expand |
Context | Check | Description |
---|---|---|
yinshiyou/make_loongarch64 | success | Make finished |
yinshiyou/make_fate_loongarch64 | success | Make fate finished |
andriy/make_x86 | success | Make finished |
andriy/make_fate_x86 | success | Make fate finished |
On Di, 2024-06-11 at 23:59 +0200, Michael Niedermayer wrote: > Fixes: CID1598548 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavfilter/qsvvpp.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c > index 1c9773df099..6adf9f6e841 100644 > --- a/libavfilter/qsvvpp.c > +++ b/libavfilter/qsvvpp.c > @@ -1099,11 +1099,6 @@ int ff_qsvvpp_create_mfx_session(void *ctx, > if (sts < 0) > return ff_qsvvpp_print_error(ctx, sts, > "Error creating a MFX session"); > - else if (sts > 0) { > - ff_qsvvpp_print_warning(ctx, sts, > - "Warning in MFX session creation"); > - return AVERROR_UNKNOWN; > - } > > *psession = session; > LGTM, thx -Haihao
On Wed, Jun 12, 2024 at 08:19:17AM +0000, Xiang, Haihao wrote: > On Di, 2024-06-11 at 23:59 +0200, Michael Niedermayer wrote: > > Fixes: CID1598548 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > --- > > libavfilter/qsvvpp.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c > > index 1c9773df099..6adf9f6e841 100644 > > --- a/libavfilter/qsvvpp.c > > +++ b/libavfilter/qsvvpp.c > > @@ -1099,11 +1099,6 @@ int ff_qsvvpp_create_mfx_session(void *ctx, > > if (sts < 0) > > return ff_qsvvpp_print_error(ctx, sts, > > "Error creating a MFX session"); > > - else if (sts > 0) { > > - ff_qsvvpp_print_warning(ctx, sts, > > - "Warning in MFX session creation"); > > - return AVERROR_UNKNOWN; > > - } > > > > *psession = session; > > > > LGTM, thx will apply thx [...]
diff --git a/libavfilter/qsvvpp.c b/libavfilter/qsvvpp.c index 1c9773df099..6adf9f6e841 100644 --- a/libavfilter/qsvvpp.c +++ b/libavfilter/qsvvpp.c @@ -1099,11 +1099,6 @@ int ff_qsvvpp_create_mfx_session(void *ctx, if (sts < 0) return ff_qsvvpp_print_error(ctx, sts, "Error creating a MFX session"); - else if (sts > 0) { - ff_qsvvpp_print_warning(ctx, sts, - "Warning in MFX session creation"); - return AVERROR_UNKNOWN; - } *psession = session;
Fixes: CID1598548 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavfilter/qsvvpp.c | 5 ----- 1 file changed, 5 deletions(-)