| Message ID | 20240616044730.21281-1-pal@sandflow.com |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel] fate/jpeg2000dec: add support for p0_10.j2k | expand |
| Context | Check | Description |
|---|---|---|
| yinshiyou/make_loongarch64 | success | Make finished |
| yinshiyou/make_fate_loongarch64 | success | Make fate finished |
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
lör 2024-06-15 klockan 21:47 -0700 skrev pal@sandflow.com: > From: Pierre-Anthony Lemieux <pal@palemieux.com> > > p0_10.j2k is one of the reference codestreams included in Rec. ITU-T > T.803 | ISO/IEC 15444-4. > --- > tests/fate/jpeg2000.mak | 3 +++ > tests/ref/fate/jpeg2000dec-p0_10 | 6 ++++++ > 2 files changed, 9 insertions(+) > create mode 100644 tests/ref/fate/jpeg2000dec-p0_10 Sounds good, assuming it decodes correctly If there are more files like this, could we add all of them in one go? /Tomas
On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin <git@haerdin.se> wrote: > > lör 2024-06-15 klockan 21:47 -0700 skrev pal@sandflow.com: > > From: Pierre-Anthony Lemieux <pal@palemieux.com> > > > > p0_10.j2k is one of the reference codestreams included in Rec. ITU-T > > T.803 | ISO/IEC 15444-4. > > --- > > tests/fate/jpeg2000.mak | 3 +++ > > tests/ref/fate/jpeg2000dec-p0_10 | 6 ++++++ > > 2 files changed, 9 insertions(+) > > create mode 100644 tests/ref/fate/jpeg2000dec-p0_10 > > Sounds good, assuming it decodes correctly > > If there are more files like this, could we add all of them in one go? I expect significantly more files to be added once the "Add support for placeholder passes, CAP, and CPF markers" patch is merged. In the meantime, I do not see a downside to updating FATE since it addresses a specific bug in trac. > > /Tomas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux: > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin <git@haerdin.se> wrote: > > > > lör 2024-06-15 klockan 21:47 -0700 skrev pal@sandflow.com: > > > From: Pierre-Anthony Lemieux <pal@palemieux.com> > > > > > > p0_10.j2k is one of the reference codestreams included in Rec. > > > ITU-T > > > T.803 | ISO/IEC 15444-4. > > > --- > > > tests/fate/jpeg2000.mak | 3 +++ > > > tests/ref/fate/jpeg2000dec-p0_10 | 6 ++++++ > > > 2 files changed, 9 insertions(+) > > > create mode 100644 tests/ref/fate/jpeg2000dec-p0_10 > > > > Sounds good, assuming it decodes correctly > > > > If there are more files like this, could we add all of them in one > > go? > > I expect significantly more files to be added once the "Add support > for placeholder passes, CAP, and CPF markers" patch is merged. In the > meantime, I do not see a downside to updating FATE since it addresses > a specific bug in trac. Alright, fair enough /Tomas
On Wed, Jun 19, 2024 at 1:42 AM Tomas Härdin <git@haerdin.se> wrote: > > tis 2024-06-18 klockan 07:59 -0700 skrev Pierre-Anthony Lemieux: > > On Tue, Jun 18, 2024 at 7:25 AM Tomas Härdin <git@haerdin.se> wrote: > > > > > > lör 2024-06-15 klockan 21:47 -0700 skrev pal@sandflow.com: > > > > From: Pierre-Anthony Lemieux <pal@palemieux.com> > > > > > > > > p0_10.j2k is one of the reference codestreams included in Rec. > > > > ITU-T > > > > T.803 | ISO/IEC 15444-4. > > > > --- > > > > tests/fate/jpeg2000.mak | 3 +++ > > > > tests/ref/fate/jpeg2000dec-p0_10 | 6 ++++++ > > > > 2 files changed, 9 insertions(+) > > > > create mode 100644 tests/ref/fate/jpeg2000dec-p0_10 > > > > > > Sounds good, assuming it decodes correctly My methodology: convert build/c1p0_10-0.pgx build/c1p0_10-1.pgx build/c1p0_10-2.pgx build/c1p0_10.png ./ffmpeg -i build/p0_10.j2k build/out.png compare -verbose -metric psnr build/c1p0_10.png build/out.png build/diff.png c1p0_10-i.pgx are from the ISO/ITU standard. > > > > > > If there are more files like this, could we add all of them in one > > > go? > > > > I expect significantly more files to be added once the "Add support > > for placeholder passes, CAP, and CPF markers" patch is merged. In the > > meantime, I do not see a downside to updating FATE since it addresses > > a specific bug in trac. > > Alright, fair enough Thanks. Will merge over the weekend. > > /Tomas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
diff --git a/tests/fate/jpeg2000.mak b/tests/fate/jpeg2000.mak index 2969d2cf0a..a99b0c4e0c 100644 --- a/tests/fate/jpeg2000.mak +++ b/tests/fate/jpeg2000.mak @@ -42,6 +42,9 @@ fate-jpeg2000dec-p0_08: CMD = framecrc -flags +bitexact -auto_conversion_filters FATE_JPEG2000DEC += fate-jpeg2000dec-p0_09 fate-jpeg2000dec-p0_09: CMD = framecrc -flags +bitexact -i $(TARGET_SAMPLES)/jpeg2000/itu-iso/codestreams_profile0/p0_09.j2k +FATE_JPEG2000DEC += fate-jpeg2000dec-p0_10 +fate-jpeg2000dec-p0_10: CMD = framecrc -flags +bitexact -i $(TARGET_SAMPLES)/jpeg2000/itu-iso/codestreams_profile0/p0_10.j2k + FATE_JPEG2000DEC += fate-jpeg2000dec-p0_11 fate-jpeg2000dec-p0_11: CMD = framecrc -flags +bitexact -i $(TARGET_SAMPLES)/jpeg2000/itu-iso/codestreams_profile0/p0_11.j2k diff --git a/tests/ref/fate/jpeg2000dec-p0_10 b/tests/ref/fate/jpeg2000dec-p0_10 new file mode 100644 index 0000000000..16c4e5e39d --- /dev/null +++ b/tests/ref/fate/jpeg2000dec-p0_10 @@ -0,0 +1,6 @@ +#tb 0: 1/25 +#media_type 0: video +#codec_id 0: rawvideo +#dimensions 0: 64x64 +#sar 0: 0/1 +0, 0, 0, 1, 12288, 0x68638483
From: Pierre-Anthony Lemieux <pal@palemieux.com> p0_10.j2k is one of the reference codestreams included in Rec. ITU-T T.803 | ISO/IEC 15444-4. --- tests/fate/jpeg2000.mak | 3 +++ tests/ref/fate/jpeg2000dec-p0_10 | 6 ++++++ 2 files changed, 9 insertions(+) create mode 100644 tests/ref/fate/jpeg2000dec-p0_10