diff mbox series

[FFmpeg-devel,7/9] MAINTAINERS: Update the entries for the release maintainer for FFmpeg

Message ID 20240616230831.912377-7-michael@niedermayer.cc
State New
Headers show
Series [FFmpeg-devel,1/9] avcodec/targaenc: Allocate space for the palette | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 success Make fate finished

Commit Message

Michael Niedermayer June 16, 2024, 11:08 p.m. UTC
Ive been told that someone at the BCN video tech meetup claimed to be the
"release maintainer for FFmpeg".

If you have any doubt who maintains releases, just do something like the following and look at the output:
VER=5.1
echo commiters ; git shortlog  --group=committer -s  n$VER..release/$VER -n ;\
echo authors   ; git shortlog                    -s  n$VER..release/$VER -n

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 MAINTAINERS | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Anton Khirnov June 17, 2024, 7:07 a.m. UTC | #1
Quoting Michael Niedermayer (2024-06-17 01:08:29)
> Ive been told that someone at the BCN video tech meetup claimed to be the
> "release maintainer for FFmpeg".
> 
> If you have any doubt who maintains releases, just do something like the following and look at the output:
> VER=5.1
> echo commiters ; git shortlog  --group=committer -s  n$VER..release/$VER -n ;\
> echo authors   ; git shortlog                    -s  n$VER..release/$VER -n

Passive aggressive gossip does not belong in a commit message.
Paul B Mahol June 17, 2024, 7:26 a.m. UTC | #2
On Mon, Jun 17, 2024 at 1:09 AM Michael Niedermayer <michael@niedermayer.cc>
wrote:

> Ive been told that someone at the BCN video tech meetup claimed to be the
> "release maintainer for FFmpeg".
>
>
That is nothing, I see many claims in many such videos and on many
platforms that they are developer/maintainer of FFmpeg while in fact they
develop/maintain only their closed source business.

Do not tell lies, or half lies, it does not help you on long run.


> If you have any doubt who maintains releases, just do something like the
> following and look at the output:
> VER=5.1
> echo commiters ; git shortlog  --group=committer -s  n$VER..release/$VER
> -n ;\
> echo authors   ; git shortlog                    -s  n$VER..release/$VER -n
>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  MAINTAINERS | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 41a98744adf..a82fa58c69f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -536,10 +536,12 @@ wm4
>  Releases
>  ========
>
> +7.0                                     Michael Niedermayer
> +6.1                                     Michael Niedermayer
> +5.1                                     Michael Niedermayer
> +4.4                                     Michael Niedermayer
> +3.4                                     Michael Niedermayer
>  2.8                                     Michael Niedermayer
> -2.7                                     Michael Niedermayer
> -2.6                                     Michael Niedermayer
> -2.5                                     Michael Niedermayer
>
>  If you want to maintain an older release, please contact us
>
> --
> 2.45.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
Michael Niedermayer June 17, 2024, 11:48 p.m. UTC | #3
On Mon, Jun 17, 2024 at 09:07:23AM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2024-06-17 01:08:29)
> > Ive been told that someone at the BCN video tech meetup claimed to be the
> > "release maintainer for FFmpeg".
> > 
> > If you have any doubt who maintains releases, just do something like the following and look at the output:
> > VER=5.1
> > echo commiters ; git shortlog  --group=committer -s  n$VER..release/$VER -n ;\
> > echo authors   ; git shortlog                    -s  n$VER..release/$VER -n
> 
> Passive aggressive gossip does not belong in a commit message.

we generally explain in a commit message the "why" and "what" and so on.
There was no intention of any aggression.

But how would you word it instead ?

The example git commands simply show the authors and commiters on the release branch
since the first release on it. I think its reasonable to provide these as reference

thx

[...]
Rémi Denis-Courmont June 18, 2024, 7:02 a.m. UTC | #4
Le 17 juin 2024 01:08:29 GMT+02:00, Michael Niedermayer <michael@niedermayer.cc> a écrit :
>Ive been told that someone at the BCN video tech meetup claimed to be the
>"release maintainer for FFmpeg".

I don't think that this is appropriate in a commit message that'll go on a blockchain never to be modifiable.

>If you have any doubt who maintains releases, just do something like the following and look at the output:

Assuming that the allegations are true, the recipients of the misinformation won't see this message so no point.
Steven Liu June 18, 2024, 9:53 a.m. UTC | #5
Michael Niedermayer <michael@niedermayer.cc> 于2024年6月17日周一 07:09写道:
>
> Ive been told that someone at the BCN video tech meetup claimed to be the
> "release maintainer for FFmpeg".
>
> If you have any doubt who maintains releases, just do something like the following and look at the output:
> VER=5.1
> echo commiters ; git shortlog  --group=committer -s  n$VER..release/$VER -n ;\
> echo authors   ; git shortlog                    -s  n$VER..release/$VER -n

(base) MacBook-Pro:ffmpeg StevenLiu$ VER=5.1
(base) MacBook-Pro:ffmpeg StevenLiu$ echo committers ; git shortlog
--group=committer -s  n$VER..release/$VER -n ;echo authors   ; git
shortlog                    -s  n$VER..release/$VER -n
committers
fatal: ambiguous argument 'n5.1..release/5.1': unknown revision or
path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
authors
fatal: ambiguous argument 'n5.1..release/5.1': unknown revision or
path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
(base) MacBook-Pro:ffmpeg StevenLiu$



>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  MAINTAINERS | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 41a98744adf..a82fa58c69f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -536,10 +536,12 @@ wm4
>  Releases
>  ========
>
> +7.0                                     Michael Niedermayer
> +6.1                                     Michael Niedermayer
> +5.1                                     Michael Niedermayer
> +4.4                                     Michael Niedermayer
> +3.4                                     Michael Niedermayer
>  2.8                                     Michael Niedermayer
> -2.7                                     Michael Niedermayer
> -2.6                                     Michael Niedermayer
> -2.5                                     Michael Niedermayer
>
>  If you want to maintain an older release, please contact us
>
> --
> 2.45.2
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Steven Liu June 18, 2024, 9:56 a.m. UTC | #6
Steven Liu <lingjiujianke@gmail.com> 于2024年6月18日周二 17:53写道:
>
> Michael Niedermayer <michael@niedermayer.cc> 于2024年6月17日周一 07:09写道:
> >
> > Ive been told that someone at the BCN video tech meetup claimed to be the
> > "release maintainer for FFmpeg".
> >
> > If you have any doubt who maintains releases, just do something like the following and look at the output:
> > VER=5.1
> > echo commiters ; git shortlog  --group=committer -s  n$VER..release/$VER -n ;\
> > echo authors   ; git shortlog                    -s  n$VER..release/$VER -n
>
> (base) MacBook-Pro:ffmpeg StevenLiu$ VER=5.1
> (base) MacBook-Pro:ffmpeg StevenLiu$ echo committers ; git shortlog
> --group=committer -s  n$VER..release/$VER -n ;echo authors   ; git
> shortlog                    -s  n$VER..release/$VER -n
> committers
> fatal: ambiguous argument 'n5.1..release/5.1': unknown revision or
> path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> authors
> fatal: ambiguous argument 'n5.1..release/5.1': unknown revision or
> path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
> (base) MacBook-Pro:ffmpeg StevenLiu$

This can fix the error message. not sure if this is right operation :D
echo committers ; git shortlog  --group=committer -s
n$VER..remotes/origin/release/$VER -n ;echo authors   ; git shortlog
                 -s  n$VER..remotes/origin/release/$VER -n


>
>
>
> >
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  MAINTAINERS | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 41a98744adf..a82fa58c69f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -536,10 +536,12 @@ wm4
> >  Releases
> >  ========
> >
> > +7.0                                     Michael Niedermayer
> > +6.1                                     Michael Niedermayer
> > +5.1                                     Michael Niedermayer
> > +4.4                                     Michael Niedermayer
> > +3.4                                     Michael Niedermayer
> >  2.8                                     Michael Niedermayer
> > -2.7                                     Michael Niedermayer
> > -2.6                                     Michael Niedermayer
> > -2.5                                     Michael Niedermayer
> >
> >  If you want to maintain an older release, please contact us
> >
> > --
> > 2.45.2
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel@ffmpeg.org
> > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> >
> > To unsubscribe, visit link above, or email
> > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Anton Khirnov June 18, 2024, 10:09 a.m. UTC | #7
Quoting Michael Niedermayer (2024-06-18 01:48:25)
> On Mon, Jun 17, 2024 at 09:07:23AM +0200, Anton Khirnov wrote:
> > Quoting Michael Niedermayer (2024-06-17 01:08:29)
> > > Ive been told that someone at the BCN video tech meetup claimed to be the
> > > "release maintainer for FFmpeg".
> > > 
> > > If you have any doubt who maintains releases, just do something like the following and look at the output:
> > > VER=5.1
> > > echo commiters ; git shortlog  --group=committer -s  n$VER..release/$VER -n ;\
> > > echo authors   ; git shortlog                    -s  n$VER..release/$VER -n
> > 
> > Passive aggressive gossip does not belong in a commit message.
> 
> we generally explain in a commit message the "why" and "what" and so on.
> There was no intention of any aggression.

The commit message is indirectly accusing an unindentified person of
trying to usurp your position as a release maintainer. The accusation is
aggressive, and the fact that it is indirect makes it passive
aggressive.

Not providing any specifics beyond "someone said that someone said"
makes it gossip.

Each of those factors in isolation IMO makes this text inappropriate for
a commit message.

> But how would you word it instead ?

I would not word it at all, as there is no evidence that this needs
clarifying. Gossip is not evidence.

> The example git commands simply show the authors and commiters on the release branch
> since the first release on it. I think its reasonable to provide these as reference

I don't. Nobody is disputing your role as a release maintainer.
Michael Niedermayer June 19, 2024, 11:22 a.m. UTC | #8
On Tue, Jun 18, 2024 at 12:09:34PM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2024-06-18 01:48:25)
> > On Mon, Jun 17, 2024 at 09:07:23AM +0200, Anton Khirnov wrote:
> > > Quoting Michael Niedermayer (2024-06-17 01:08:29)
> > > > Ive been told that someone at the BCN video tech meetup claimed to be the
> > > > "release maintainer for FFmpeg".
> > > > 
> > > > If you have any doubt who maintains releases, just do something like the following and look at the output:
> > > > VER=5.1
> > > > echo commiters ; git shortlog  --group=committer -s  n$VER..release/$VER -n ;\
> > > > echo authors   ; git shortlog                    -s  n$VER..release/$VER -n
> > > 
> > > Passive aggressive gossip does not belong in a commit message.
> > 
> > we generally explain in a commit message the "why" and "what" and so on.
> > There was no intention of any aggression.
> 
> The commit message is indirectly accusing an unindentified person of
> trying to usurp your position as a release maintainer. The accusation is
> aggressive, and the fact that it is indirect makes it passive
> aggressive.
> 
> Not providing any specifics beyond "someone said that someone said"
> makes it gossip.
> 
> Each of those factors in isolation IMO makes this text inappropriate for
> a commit message.

I dont entirely agree but ill drop it from the commit message.


[...]

> > The example git commands simply show the authors and commiters on the release branch
> > since the first release on it. I think its reasonable to provide these as reference
> 
> I don't. Nobody is disputing your role as a release maintainer.

Its always nice to learn that iam A release maintainer and not THE release maintainer. :)
Which releases are maintained by someone else ?
And who is that someone else ?
Can that other release maintainer look at some of the regressions we have?
IIRC there are cases that since the multithreding dont 100% of the time
produce the same output, it makes testing more difficult. And while
already at that subject can that other release maintainer help marking
regressions as such and as release blocking ? So they are more vissible
and can get fixed.

thx

[...]
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index 41a98744adf..a82fa58c69f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -536,10 +536,12 @@  wm4
 Releases
 ========
 
+7.0                                     Michael Niedermayer
+6.1                                     Michael Niedermayer
+5.1                                     Michael Niedermayer
+4.4                                     Michael Niedermayer
+3.4                                     Michael Niedermayer
 2.8                                     Michael Niedermayer
-2.7                                     Michael Niedermayer
-2.6                                     Michael Niedermayer
-2.5                                     Michael Niedermayer
 
 If you want to maintain an older release, please contact us