diff mbox series

[FFmpeg-devel,08/11] fftools/ffmpeg: Check read() for failure

Message ID 20240630231306.3779027-8-michael@niedermayer.cc
State New
Headers show
Series [FFmpeg-devel,01/11] MAINTAINERS: Add Timo Rothenpieler to server admins | expand

Checks

Context Check Description
yinshiyou/make_loongarch64 success Make finished
yinshiyou/make_fate_loongarch64 fail Make fate failed
andriy/make_x86 success Make finished
andriy/make_fate_x86 success Make fate finished

Commit Message

Michael Niedermayer June 30, 2024, 11:12 p.m. UTC 
Fixes: CID1591932 Ignoring number of bytes read
Untested, this needs a windows machine

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 fftools/ffmpeg.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Anton Khirnov July 1, 2024, 11:09 a.m. UTC | #1 
Quoting Michael Niedermayer (2024-07-01 01:12:47)
> Fixes: CID1591932 Ignoring number of bytes read
> Untested, this needs a windows machine
> 
> Sponsored-by: Sovereign Tech Fund
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  fftools/ffmpeg.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Looks ok.
diff mbox series

Patch

diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 88ce3007e83..8674c4d2506 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -285,8 +285,9 @@  static int read_key(void)
         }
         //Read it
         if(nchars != 0) {
-            read(0, &ch, 1);
-            return ch;
+            if (read(0, &ch, 1) == 1)
+                return ch;
+            return 0;
         }else{
             return -1;
         }