| Message ID | 20240710225012.691594-1-michael@niedermayer.cc |
|---|---|
| State | New |
| Headers | show |
| Series | [FFmpeg-devel,1/6] avfilter/vf_tiltandshift: Free dst on error | expand |
| Context | Check | Description |
|---|---|---|
| andriy/make_x86 | success | Make finished |
| andriy/make_fate_x86 | success | Make fate finished |
On Thu, Jul 11, 2024 at 12:50 AM Michael Niedermayer <michael@niedermayer.cc> wrote: > Fixes: CID1559901 Resource leak > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > --- > libavfilter/vf_tiltandshift.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/vf_tiltandshift.c b/libavfilter/vf_tiltandshift.c > index b49a713339d..08bcb062473 100644 > --- a/libavfilter/vf_tiltandshift.c > +++ b/libavfilter/vf_tiltandshift.c > @@ -237,8 +237,10 @@ static int output_frame(AVFilterLink *outlink) > > // set correct timestamps and props as long as there is proper input > ret = av_frame_copy_props(dst, s->input); > - if (ret < 0) > + if (ret < 0) { > + av_frame_free(&dst); > return ret; > + } > > // discard frame at the top of the list since it has been fully > processed > list_remove_head(s); > -- > lgtm
On Fri, Jul 12, 2024 at 12:19:29AM +0200, Vittorio Giovara wrote: > On Thu, Jul 11, 2024 at 12:50 AM Michael Niedermayer <michael@niedermayer.cc> > wrote: > > > Fixes: CID1559901 Resource leak > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> > > --- > > libavfilter/vf_tiltandshift.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libavfilter/vf_tiltandshift.c b/libavfilter/vf_tiltandshift.c > > index b49a713339d..08bcb062473 100644 > > --- a/libavfilter/vf_tiltandshift.c > > +++ b/libavfilter/vf_tiltandshift.c > > @@ -237,8 +237,10 @@ static int output_frame(AVFilterLink *outlink) > > > > // set correct timestamps and props as long as there is proper input > > ret = av_frame_copy_props(dst, s->input); > > - if (ret < 0) > > + if (ret < 0) { > > + av_frame_free(&dst); > > return ret; > > + } > > > > // discard frame at the top of the list since it has been fully > > processed > > list_remove_head(s); > > -- > > > > lgtm will apply thx [...]
diff --git a/libavfilter/vf_tiltandshift.c b/libavfilter/vf_tiltandshift.c index b49a713339d..08bcb062473 100644 --- a/libavfilter/vf_tiltandshift.c +++ b/libavfilter/vf_tiltandshift.c @@ -237,8 +237,10 @@ static int output_frame(AVFilterLink *outlink) // set correct timestamps and props as long as there is proper input ret = av_frame_copy_props(dst, s->input); - if (ret < 0) + if (ret < 0) { + av_frame_free(&dst); return ret; + } // discard frame at the top of the list since it has been fully processed list_remove_head(s);
Fixes: CID1559901 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer <michael@niedermayer.cc> --- libavfilter/vf_tiltandshift.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)